New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615308 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tab focus is not seen on options under 'View site info' overlay.

Reported by rk...@etouch.net, May 27 2016

Issue description

Chrome Version: 53.0.2750.0 Revision c84885e83ecac137b93ed2b6c8b7323d8e91ffe1-refs/heads/master@{#396337}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to google.com
(2) Click on 'View site info' icon and press Tab key, observe focus traverse.

Tab focus is not seen on option under 'Permissions'

Tab focus should be seen on option under 'Permissions'

This is a regression issue, broken in 'M-53', will soon update the other info:

Good Build: 53.0.2749.0
Bad Build: 53.0.2750.0


 
Actual_Focus.mp4
435 KB Download
Expected_Focus.mp4
397 KB Download

Comment 1 by rk...@etouch.net, May 27 2016

Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/6b4fb0f9025c4cf34374afd19a1a18da058c2796..6f7075c5e44eeb1f99f514e6e8bf53f844f41aa9?pretty=fuller&n=50

Suspecting: r396328

Note: Issue is not seen Mac OS, will soon update the Linux OS info.

Comment 2 by kochi@chromium.org, May 27 2016

Components: -Blink>Focus UI>Browser>Permissions
This UI is not a part of Blink.
Forwarding to permissions UI.

Comment 3 by rk...@etouch.net, May 27 2016

Labels: OS-Linux
Above issue is also seen Linux OS.
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this is a recent regression.

Thank you!

Comment 5 by est...@chromium.org, May 27 2016

will be a lot easier to fix when https://codereview.chromium.org/2011963002/ lands --- we can just switch over to using comboboxes for the MD version.

Comment 6 by est...@chromium.org, Jun 15 2016

Cc: est...@chromium.org benwells@chromium.org palmer@chromium.org ajha@chromium.org
 Issue 618182  has been merged into this issue.

Comment 7 by est...@chromium.org, Jun 15 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2069733002/
Just to update, Still able to reproduce the issue on windows 7 using chrome version 53.0.2773.0.

estade@ Gentle Ping !

 

Comment 9 by est...@chromium.org, Jun 20 2016

I'm working on it, see above link
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399800ecfbe6b923f0a2c64bd83d21d50a97d399

commit 399800ecfbe6b923f0a2c64bd83d21d50a97d399
Author: estade <estade@chromium.org>
Date: Wed Jun 22 16:29:22 2016

MD - Use real comboboxes in website settings popup.

In MD,
1. Hide borders (but leave focus border intact).
2. Move arrow closer to text instead of sizing based on widest option text.

Also fix bug where button focus borders depended on the --top-chrome-md flag even if they were in secondary UI. Thus with top chrome md enabled and secondary chrome md disabled, we get the normal pre-MD focus rects.

BUG= 615308 

Review-Url: https://codereview.chromium.org/2069733002
Cr-Commit-Position: refs/heads/master@{#401301}

[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/chrome/browser/ui/views/website_settings/permission_selector_view.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/ui/views/controls/button/blue_button_unittest.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/399800ecfbe6b923f0a2c64bd83d21d50a97d399/ui/views/controls/combobox/combobox.h

Status: Fixed (was: Started)

Sign in to add a comment