[Android] Cancel button on download dangerous file infobar can crash sometimes
Reported by
mcda...@amazon.com,
May 27 2016
|
|||||
Issue descriptionChrome Version : latest from master Steps to reproduce the problem: 1. Open a 'dangerous' link (a .apk file, for example) in a new tab, whether through the link automatically opening in a new tab, or through context menu "Open in new tab" 2. Press cancel in the infobar that appears. Cancelling must cause the new tab to be closed. What is the expected behavior? The tab closes, the download is cancelled, the browser continues behaving as normal What went wrong? The browser crashes sometimes (< 50%)
,
May 27 2016
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0861c56c582da4866a84104dc5764a8adad84dd6 commit 0861c56c582da4866a84104dc5764a8adad84dd6 Author: mcdavid <mcdavid@amazon.com> Date: Wed Jun 01 01:36:15 2016 [Android] Fix crash when closing tab during infobar cancellation Cancelling the 'dangerous file' dialog could cause the current tab to be closed, triggering the infobar to be deleted. The now deleted infobar would then try to close itself after cancellation, causing a crash. Also reworks InfoBarUtil to click infobar buttons directly rather than through tap events, reducing flakiness. BUG= 615280 TEST=DownloadTest,GeolocationTest,InfoBarTest,InfoBarContainerTest Review-Url: https://codereview.chromium.org/2019533002 Cr-Commit-Position: refs/heads/master@{#397017} [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc [modify] https://crrev.com/0861c56c582da4866a84104dc5764a8adad84dd6/chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java
,
Jun 3 2016
Is this issue fixed?
,
Jun 3 2016
Looks not super related to my work. Re-assign to reviewers of the CL instead.
,
Jun 3 2016
Likely to have been fixed by mcdavid's patch. Marking fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mcda...@amazon.com
, May 27 2016