New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615259 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 829310



Sign in to add a comment

"TabindexOpenDialog/FileManagerBrowserTest.Test/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 26 2016

Issue description

"TabindexOpenDialog/FileManagerBrowserTest.Test/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBUYWJpbmRleE9wZW5EaWFsb2cvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzAM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by suzyh@chromium.org, May 27 2016

Cc: ellyjo...@chromium.org
Owner: roc...@chromium.org
I'm seeing flaky timeouts on Linux ChromiumOS since about a day and a half ago: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=TabindexOpenDialog

From the revision range suggested there (http://test-results.appspot.com/revision_range?start=395898&end=395909) I found
https://codereview.chromium.org/1991323002 and https://codereview.chromium.org/2000863002 that touch chrome/browser.

rockot, ellyjones: could you take a look and help route this bug to the right place?

Comment 2 by suzyh@chromium.org, May 27 2016

 Issue 615147  has been merged into this issue.

Comment 3 by suzyh@chromium.org, May 27 2016

 Issue 615237  has been merged into this issue.

Comment 4 by suzyh@chromium.org, May 27 2016

 Issue 615258  has been merged into this issue.

Comment 5 by suzyh@chromium.org, May 27 2016

Cc: suzyh@chromium.org

Comment 6 by roc...@chromium.org, May 27 2016

Cc: roc...@chromium.org
Owner: fukino@chromium.org
I doubt either of those CLs would be responsible for this. Definitely not ellyjones' and very unlikely mine.

fukino@ could you take a look to see if this could be caused by r396108? It's not in the revision range mentioned above, but I do see it in the blame list of the first flaky failure and suspiciously the flake is related to file manager tests.
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, May 27 2016

Detected 3 new flakes for test/step "TabindexSaveFileDialog/FileManagerBrowserTest.Test/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRUYWJpbmRleFNhdmVGaWxlRGlhbG9nL0ZpbGVNYW5hZ2VyQnJvd3NlclRlc3QuVGVzdC8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, May 27 2016

Detected 3 new flakes for test/step "TabindexSaveFileDialog/FileManagerBrowserTest.Test/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRUYWJpbmRleFNhdmVGaWxlRGlhbG9nL0ZpbGVNYW5hZ2VyQnJvd3NlclRlc3QuVGVzdC8xDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 9 by fukino@chromium.org, May 30 2016

Cc: fukino@chromium.org
Owner: oka@chromium.org
Status: Assigned (was: Untriaged)
r396108 shouldn't be related to this flakiness, but something should be wrong with this TabindexSaveFileDialog test.

oka@, could you disable the test and re-enable after the cause of the flakiness is fixed?
Project Member

Comment 11 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789e5a5b2134494640959a66bb3b4f648e78ba4a

commit 789e5a5b2134494640959a66bb3b4f648e78ba4a
Author: oka <oka@chromium.org>
Date: Mon May 30 13:03:21 2016

Disable flaky TabindexOpenDialog/FileManagerBrowserTest.

BUG= 615259 

Review-Url: https://codereview.chromium.org/2026433004
Cr-Commit-Position: refs/heads/master@{#396719}

[modify] https://crrev.com/789e5a5b2134494640959a66bb3b4f648e78ba4a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Project Member

Comment 12 by chromium...@appspot.gserviceaccount.com, May 30 2016

Detected 3 new flakes for test/step "TabindexSaveFileDialog/FileManagerBrowserTest.Test/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRUYWJpbmRleFNhdmVGaWxlRGlhbG9nL0ZpbGVNYW5hZ2VyQnJvd3NlclRlc3QuVGVzdC8wDA. This message was posted automatically by the chromium-try-flakes app.
Ah, I guess TabindexSaveFileDialog has the same problem.
oka@, could you disable it, too?
Labels: -Sheriff-Chromium
Removing from Sheriff bug queue since this has assigned an owner.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d5d4e478840619dbc9dbfa704aa7ec155a162b9

commit 5d5d4e478840619dbc9dbfa704aa7ec155a162b9
Author: oka <oka@chromium.org>
Date: Wed Jun 01 02:33:23 2016

Disable flaky TabindexSaveFileDialog/FileManagerBrowserTest.

BUG= 615259 

Review-Url: https://codereview.chromium.org/2022223002
Cr-Commit-Position: refs/heads/master@{#397028}

[modify] https://crrev.com/5d5d4e478840619dbc9dbfa704aa7ec155a162b9/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Cc: -suzyh@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a3dd064413a8d341253c27cb944ba739acba2c

commit 54a3dd064413a8d341253c27cb944ba739acba2c
Author: tetsui <tetsui@google.com>
Date: Tue Apr 11 01:50:55 2017

Enable once flaky tests in Chrome OS file manager.

These tests were previously flaky and there seems to be a shared issue.
However, they do not reproduce anymore on the latest master branch.

It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and
it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac.

BUG= 699426 , 700156 , 699083 , 698834 , 702119 , 701923 , 699171 , 699978 , 702119 , 699534 , 615259 , 698772 
TEST=none
TBR=fukino@chromium.org

Review-Url: https://codereview.chromium.org/2801573002
Cr-Commit-Position: refs/heads/master@{#463493}

[modify] https://crrev.com/54a3dd064413a8d341253c27cb944ba739acba2c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 19 by kbr@chromium.org, Apr 5 2018

Blockedon: 829310

Comment 20 by noel@chromium.org, Apr 19 2018

Cc: oka@chromium.org
Owner: noel@chromium.org
Status: WontFix (was: Assigned)
This test is not currently running on the bots [1].  When we get to re-enabling this test, will address, but for now, nothing to fix WONTFIX

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=TabindexOpenDialog%2FFileManagerBrowserTest.Test%2F0

Sign in to add a comment