New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615250 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get hotrod tests to work with Chameleon

Project Member Reported by harpreet@chromium.org, May 26 2016

Issue description

With the current setup, we use a server side test to clear tpm and remove some directories/files to bring the device into a non-enrolled clean state. Once in this state, we call a client side test to enroll the device into hotrod with enterprise_RemoraRequisition test https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/enterprise_RemoraRequisition/enterprise_RemoraRequisition.py


We want to be able to use Chameleon and audio boards for validating audio on a CFM/hotrod enrolled device. This can only be done from a server side test, hence we need to convert the client side enterprise_RemoraRequisition test to a server side test before we can proceed with writing other audio and video tests for hotrod enrolled devices.

Server side enterprise_RemoraRequisition test for reference: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/site_tests/enterprise_RemoraRequisitionServer/enterprise_RemoraRequisitionServer.py
 

Comment 1 by ka...@chromium.org, May 26 2016

Cc: cychiang@chromium.org
Adding Jimmy for any clarifications needed down the road.
Cc: harpreet@chromium.org conradlo@chromium.org johnylin@chromium.org
Status: Assigned (was: Untriaged)
The enrollment is done by passing different arguments to create a Chrome object. So a different facade resource has to be supported for this need. I will work on adding this new facade resource and related APIs change.
I drafted a CL in:
  https://chromium-review.googlesource.com/350096

Now the XML RPC server starts without Chrome. Then you can start a new Chrome (multiple time) with special arguments, like the code:

        factory = remote_facade_factory.RemoteFacadeFactory(host, no_chrome=True)
        browser_facade = factory.create_browser_facade()
        browser_facade.start_custom_chrome(...)
        
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2ecf0e775e6a19152495003cf90410f53686af30

commit 2ecf0e775e6a19152495003cf90410f53686af30
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Mon Jun 06 23:09:08 2016

Chameleon: Support starting multimedia XML RPC server without Chrome

Add the support of no chrome when starting the RPC server such that
a test can pass some different arguments to start a custom Chrome,
by using a new RPC browser_facade.start_custom_chrome(kwargs).

BUG= chromium:615250 
TEST=Ran several Chameleon tests and verified they still passed.

Change-Id: Ic44ed8138ce55702a66a6f6aeaa99970f10f58ff
Reviewed-on: https://chromium-review.googlesource.com/350096
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/server/cros/multimedia/browser_facade_adapter.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/server/cros/multimedia/remote_facade_factory.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/server/cros/audio/audio_test.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/server/cros/chameleon/chameleon_measurer.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/client/cros/multimedia/audio_facade_native.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/client/cros/multimedia/facade_resource.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/client/cros/constants.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/client/cros/multimedia/multimedia_xmlrpc_server.py
[modify] https://crrev.com/2ecf0e775e6a19152495003cf90410f53686af30/client/cros/multimedia/browser_facade_native.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665

commit 4b3d16d9342ababf6b2a30b4126fdfad4c1f2665
Author: harpreet <harpreet@google.com>
Date: Wed Jun 22 03:54:23 2016

Adding support to get hotrod tests to work over xmlrpc

Add CFM facades for hotrod tests to work over xmlrpc to be able to
trigger telemetry commands from server tests, including chameleon tests.

BUG= chromium:615250 
TEST=Tested against local setup.

Change-Id: I0718ad60d31429961424faf1c28898a7376b52db
Reviewed-on: https://chromium-review.googlesource.com/354774
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665/server/cros/multimedia/remote_facade_factory.py
[modify] https://crrev.com/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665/client/cros/multimedia/multimedia_xmlrpc_server.py
[add] https://crrev.com/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665/client/cros/multimedia/cfm_facade_native.py
[add] https://crrev.com/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665/server/cros/multimedia/cfm_facade_adapter.py
[modify] https://crrev.com/4b3d16d9342ababf6b2a30b4126fdfad4c1f2665/client/cros/multimedia/facade_resource.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment