New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615245 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[webview] playing video on Dolphin/ESPN full screen layout blocking the video

Project Member Reported by dneelame...@chromium.org, May 26 2016

Issue description

This report will ONLY be viewable by Google.

Device name:
Android version: Galaxy S7/MMB29M
WebView version : 51.0.2704.67
Application version: Dolphin browser/V11.5.6

URLs (if applicable):
https://play.google.com/store/apps/details?id=mobi.mgeek.TunnyBrowser&hl=en


Steps to reproduce:
(1) Launch Dolphin > go to setting > Disable Jet back
(2) Go to Home screen of the dolphin > Click on ESPN, From ESPN (espn.go.com), select any video > hit play button > make it full screen



Expected result:
Video play in full screen

Actual result:
-playing video on Dolphin/ESPN full screen layout blocking the video

Additional info:
-Attaching logcat and video
-Regression issues (current stable build is working fine M50/.86)

Bisect info
-Last working build is - 51.0.2704.38
-Broken build is - 51.0.2704.40

 

Comment 1 Deleted

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
log/screenshot/video - > go/chrome-androidlogs1/6/615245
Cc: qin...@chromium.org

Comment 5 by sgu...@chromium.org, May 27 2016

likely this one:
https://codereview.chromium.org/1907753002

Comment 6 by sgu...@chromium.org, May 27 2016

Owner: w...@chromium.org
or this.  https://codereview.chromium.org/1952133003

Comment 7 by sgu...@chromium.org, May 27 2016

Labels: -Restrict-View-Google

Comment 8 by sgu...@chromium.org, May 27 2016

Is this problem only specific to Dolphin and ESPN? does it show up in other sites serving full screen videos such as CNN, android browser shell. 

Comment 9 by hush@chromium.org, May 27 2016

Cc: hush@chromium.org
Labels: -ReleaseBlock-Stable
This app is not even using WebView. And we can't reproduce this issue locally. To verify this is not using webview, you can add --show-composited-layer-borders to command line args.
sgurun@, For now I'm seeing the issue only on dolphin/ESPN 

Note:-
-I checked on Android Webview Shell  browser on ESPN, There is no option to make Video to full screen and I'm not layout over laying issues.
 
-And checked Dolphin on CNN/BBC/NBC I'm not seeing this issue.
hush@, can you please make sure you are disabling in the jetpack to usewebview

Under "setting > Disable Jet pack", then you will see the comment line border

Labels: ReleaseBlock-Stable
adding rbs back. satya demoed the issue on a samsung phone. 
definitely can't repro on nexus 5
hush reproed it on a Nexus5xp

Comment 15 Deleted

Cc: dalecur...@chromium.org
revert of https://codereview.chromium.org/1907753002 works. My understanding is this means we have to choose between crbug/603521 and this
issue 603521 doesn't affect M51, so go ahead and revert from M51, we'll keep the other issue open for M52.
Status: Fixed (was: Available)
https://chromium.googlesource.com/chromium/src.git/+/3d7916e49d626af16940e9d8148e655d436b669d is the landed revert.  We should be good to go.
Labels: -M-51 M-52
Status: Assigned (was: Fixed)
Actually, sorry - I'm going to leave this open and target to M52 as RB-Stable as we'll still have to address this once the unified pipeline is turned back on.
Verified/fixed on M51(latest web view build)/S7/ATT

Will leave the bug as it as for M52 as per above comment.

Comment 21 by ti...@chromium.org, Jun 21 2016

Cc: ti...@chromium.org

Comment 22 by w...@chromium.org, Jun 21 2016

CL out for review here https://codereview.chromium.org/2084223002
Labels: Proj-Spitzer
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/014e89fdbe83fd895898331249f9bba28cc71130

commit 014e89fdbe83fd895898331249f9bba28cc71130
Author: watk <watk@chromium.org>
Date: Fri Jun 24 18:56:45 2016

Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG= 615245 , 603521

Review-Url: https://codereview.chromium.org/2083223002
Cr-Commit-Position: refs/heads/master@{#401916}

[modify] https://crrev.com/014e89fdbe83fd895898331249f9bba28cc71130/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Comment 25 by w...@chromium.org, Jun 24 2016

Labels: Merge-Request-52
I have confirmed this fixes the bug in Dolphin and elsewhere.

Comment 26 by dimu@google.com, Jun 24 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 27 Deleted

I'm seeing this issue on DU browser/ESPN as well

Comment 29 by w...@chromium.org, Jun 24 2016

With which build? The fix only went in 4 hrs ago. So unless you're testing with a tip of master build, you won't see the fix.

Comment 30 by w...@chromium.org, Jun 27 2016

This was merged to 52. It did not make it into 52.0.2743.49 though. It will be in the next one. I'll leave this open to verify on the next beta. 
Project Member

Comment 31 by sheriffbot@chromium.org, Jun 28 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Verified on latest M52 and M53 webview builds, this issue is fixed.



Comment 33 by w...@chromium.org, Jun 28 2016

Status: Fixed (was: Assigned)
Thanks for verifying

Comment 34 by boliu@chromium.org, Jun 28 2016

Merge for m52 already happened?

Comment 35 by w...@chromium.org, Jun 28 2016

Labels: -Hotlist-Merge-Approved Merge-Merged
Yep. The script that usually posts comments isn't working apparently so I updated the labels
Status: Verified (was: Fixed)
marking verified 
Labels: -Merge-Approved-52
Removing merge approval per c#35

Sign in to add a comment