[Navigation] Remove trailing slash from otherwise valid routes |
|||||
Issue descriptionIt seems that whenever a URL is not recognized as a predefined path the "basic" page is returned. Examples Issue 1: Trailing slash chrome://md-settings/advanced, recognized, returns the "advanced" page chrome://md-settings/advanced/, not recognized, returns the "basic" page Suggestion: Should return same page, with or without trailing slash. Issue2 : Typos chrome://md-settings/searchEngines, recognized, returns the "search engines" page chrome://md-settings/searchEgnines, not recognized due to typo, returns the "basic" page Suggestion: Should return 404, page not found when a typo exists, instead of defaulting to the "basic" page.
,
Jul 22 2016
,
Sep 20 2016
,
Nov 19 2016
This seems fairly easy https://codereview.chromium.org/2518763002.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67c02ed84a243982e46ed96bdf392ee213b5fef1 commit 67c02ed84a243982e46ed96bdf392ee213b5fef1 Author: dpapad <dpapad@chromium.org> Date: Tue Nov 29 01:41:12 2016 MD Settings: Allow trailing slashes in otherwise valid URLs. BUG= 615242 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2518763002 Cr-Commit-Position: refs/heads/master@{#434816} [modify] https://crrev.com/67c02ed84a243982e46ed96bdf392ee213b5fef1/chrome/browser/resources/settings/route.js [modify] https://crrev.com/67c02ed84a243982e46ed96bdf392ee213b5fef1/chrome/test/data/webui/settings/route_tests.js
,
Nov 30 2016
Marking this as fixed. Trailing slashes are now allowed. Typos are still handled as they were before. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbuck...@chromium.org
, May 27 2016Status: Available (was: Untriaged)
Summary: [Navigation] Remove trailing slash from otherwise valid routes (was: MD Settings: URL routing sometimes confusing.)