New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615224 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 613279


Sign in to add a comment

[Mac][MaterialDesign] Bookmarks Bar: Bookmarks without title (favicon only) are not centered horizontally within the hover button.

Project Member Reported by meh...@chromium.org, May 26 2016 
Version: Chromium 396199 - 53.0.2750.0 (Developer Build) 
OS: 10.11

What steps will reproduce the problem?
(1) Save bookmarks without the title to the Bookmarks Bar, so that only the favicon is to see
(2) Hover over the bookmarks

What is the expected output? What do you see instead?
The Favicons are not centered horizontally within the hover button

Please use labels and text to provide additional information.
Screenshots are attached.

Thanks and regards
Mehmet
actual_not_centered_horizontally.png
38.9 KB View Download
expected_centered_horizontally.png
51.8 KB View Download

Comment 1 by shrike@chromium.org, May 26 2016

Labels: Needs-Feedback
Status: Started (was: Assigned)

Comment 2 by shrike@chromium.org, May 26 2016

Blockedon: 613279
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384032da30351eb07a56b86e9dd38e316add54d6

commit 384032da30351eb07a56b86e9dd38e316add54d6
Author: shrike <shrike@chromium.org>
Date: Tue May 31 17:14:27 2016

[Mac][Material Design] Bring bookmark hover state,  etc. up to spec.

This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.

R=avi@chromium.org
BUG= 613279 , 615224 , 615163 , 613086 

Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
Cr-Commit-Position: refs/heads/master@{#396195}

Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396851}

[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/gradient_button_cell.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2016

Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e06c09b0327766bbca9a09b375586fe89e9b9cd

commit 8e06c09b0327766bbca9a09b375586fe89e9b9cd
Author: Jayson Adams <shrike@chromium.org>
Date: Thu Jun 02 18:46:04 2016

[Mac][Material Design] Bring bookmark hover state,  etc. up to spec.

This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.

R=avi@chromium.org
BUG= 613279 , 615224 , 615163 , 613086 

Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
Cr-Commit-Position: refs/heads/master@{#396195}

Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396851}
(cherry picked from commit 384032da30351eb07a56b86e9dd38e316add54d6)

Review URL: https://codereview.chromium.org/2034813002 .

Cr-Commit-Position: refs/branch-heads/2743@{#195}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/gradient_button_cell.mm

Comment 5 by shrike@chromium.org, Jun 2 2016

Status: Fixed (was: Started)

Comment 6 by ajha@chromium.org, Jun 8 2016

Labels: -Needs-Feedback TE-Verified-52.0.2743.33 TE-Verified-M52
Verified the merge on the latest M-52(52.0.2743.33) on Mac OS 10.11.5. Favicon with no title is centered properly on Bookmarkbar. Attached is the screenshot for the same.
615224.png
304 KB View Download
►

Sign in to add a comment