Use metrics_reporting_state APIs from Mac & Linux first run dialogs |
||
Issue descriptionUse metrics_reporting_state APIs from Mac & Linux first run dialogs. Currently they manually fiddle with GoogleUpdateSettings::GetCollectStatsConsent() and metrics::prefs::kMetricsReportingEnabled, which they shouldn't do. Also, they do not actually start the metrics service.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aebe925d51198f3ad6c964a8a9afa96ecabdafe2 commit aebe925d51198f3ad6c964a8a9afa96ecabdafe2 Author: asvitkine <asvitkine@chromium.org> Date: Fri May 27 19:48:03 2016 Make Mac and Linux first run dialogs use metrics APIs. This makes the two implementations use the APIs from chrome/browser/metrics/metrics_reporting_state.h to check if the pref is managed and to set it. This also fixes a bug where the metrics service wouldn't be started on first run because neither of the two existing implementations would call Start() on it, which is fixed by using InitiateMetricsReportingChange() which does this. BUG= 615203 Review-Url: https://codereview.chromium.org/2014353002 Cr-Commit-Position: refs/heads/master@{#396537} [modify] https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2/chrome/browser/first_run/first_run_internal_posix.cc [modify] https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2/chrome/browser/ui/cocoa/first_run_dialog.mm [modify] https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2/chrome/browser/ui/views/first_run_dialog.cc
,
May 27 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, May 26 2016