AwContentsRenderTest#testForceDrawWhenInvisible is flaky |
|||||||
Issue description
The test org.chromium.android_webview.test.AwContentsRenderTest#testForceDrawWhenInvisible flaked in the android_webview_test_apk tests.
Logcat:
C 376.133s Main Detailed Logs
C 376.133s Main ********************************************************************************
C 376.134s Main [FAIL] org.chromium.android_webview.test.AwContentsRenderTest#testForceDrawWhenInvisible with {--webview-sandboxed-renderer}:
C 376.134s Main java.lang.RuntimeException: Error occured waiting for callable
C 376.134s Main at org.chromium.base.ThreadUtils.runOnUiThreadBlockingNoException(ThreadUtils.java:91)
C 376.134s Main at org.chromium.android_webview.test.util.GraphicsTestUtils.drawAwContentsOnUiThread(GraphicsTestUtils.java:34)
C 376.134s Main at org.chromium.android_webview.test.AwContentsRenderTest.testForceDrawWhenInvisible(AwContentsRenderTest.java:121)
C 376.134s Main at java.lang.reflect.Method.invokeNative(Native Method)
C 376.134s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C 376.134s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C 376.134s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 376.134s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 376.134s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 376.134s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 376.134s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 376.134s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C 376.134s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C 376.134s Main Caused by: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: width and height must be > 0
C 376.134s Main at java.util.concurrent.FutureTask.report(FutureTask.java:93)
C 376.134s Main at java.util.concurrent.FutureTask.get(FutureTask.java:163)
C 376.134s Main at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:107)
C 376.134s Main at org.chromium.base.ThreadUtils.runOnUiThreadBlockingNoException(ThreadUtils.java:89)
C 376.134s Main ... 18 more
C 376.134s Main Caused by: java.lang.IllegalArgumentException: width and height must be > 0
C 376.134s Main at android.graphics.Bitmap.createBitmap(Bitmap.java:808)
C 376.134s Main at android.graphics.Bitmap.createBitmap(Bitmap.java:787)
C 376.134s Main at android.graphics.Bitmap.createBitmap(Bitmap.java:754)
C 376.134s Main at org.chromium.android_webview.test.util.GraphicsTestUtils.doDrawAwContents(GraphicsTestUtils.java:93)
C 376.134s Main at org.chromium.android_webview.test.util.GraphicsTestUtils.drawAwContents(GraphicsTestUtils.java:29)
C 376.134s Main at org.chromium.android_webview.test.util.GraphicsTestUtils$1.call(GraphicsTestUtils.java:37)
C 376.134s Main at org.chromium.android_webview.test.util.GraphicsTestUtils$1.call(GraphicsTestUtils.java:34)
C 376.134s Main at java.util.concurrent.FutureTask.run(FutureTask.java:237)
C 376.134s Main at android.os.Handler.handleCallback(Handler.java:733)
C 376.134s Main at android.os.Handler.dispatchMessage(Handler.java:95)
C 376.134s Main at android.os.Looper.loop(Looper.java:136)
C 376.134s Main at android.app.ActivityThread.main(ActivityThread.java:5001)
C 376.135s Main at java.lang.reflect.Method.invokeNative(Native Method)
C 376.135s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
C 376.135s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
C 376.135s Main at dalvik.system.NativeStart.main(Native Method)
C 376.135s Main ********************************************************************************
Assigning to sgurun@ for now.
,
May 26 2016
,
May 26 2016
This has flaked three times in the past 24 hours on that bot. It should be fixed or disabled soon.
,
May 26 2016
disable cl is landing
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ec12b63245301276d99d8b8bafb28e8a3ab6f0f commit 9ec12b63245301276d99d8b8bafb28e8a3ab6f0f Author: sgurun <sgurun@chromium.org> Date: Thu May 26 21:56:17 2016 Disable flaky test The testForceDrawWhenInvisible seems to be failing intermittently. BUG= 615184 Review-Url: https://codereview.chromium.org/2016853002 Cr-Commit-Position: refs/heads/master@{#396293} [modify] https://crrev.com/9ec12b63245301276d99d8b8bafb28e8a3ab6f0f/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
,
May 26 2016
hush can you investigate. --webview-sandboxed-renderer
,
May 28 2016
,
May 28 2016
making it blocked because we want to revert this change once the blocking bug is fixed.
,
May 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3299e6dd6c23522dad7b90cf74d4b184ef21d998 commit 3299e6dd6c23522dad7b90cf74d4b184ef21d998 Author: sgurun <sgurun@chromium.org> Date: Sat May 28 02:30:13 2016 Reenable test for single process scenario The test was completely disabled while it was only failing for multi-process. Reenable it for singleprocess. BUG= 615184 Review-Url: https://codereview.chromium.org/2025473002 Cr-Commit-Position: refs/heads/master@{#396627} [modify] https://crrev.com/3299e6dd6c23522dad7b90cf74d4b184ef21d998/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
,
May 31 2016
Caused by: java.lang.IllegalArgumentException: width and height must be > 0 :| Why use css pixels at all here. That makes no sense..
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c53cb19c99a47490a6d5b4d44c35ef256ca4eac2 commit c53cb19c99a47490a6d5b4d44c35ef256ca4eac2 Author: boliu <boliu@chromium.org> Date: Wed Jun 01 01:24:06 2016 aw: Fix testForceDrawWhenInvisible Use view size rather than content size, since content size might still be empty before draw. BUG= 615184 Review-Url: https://codereview.chromium.org/2027013002 Cr-Commit-Position: refs/heads/master@{#397014} [modify] https://crrev.com/c53cb19c99a47490a6d5b4d44c35ef256ca4eac2/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
,
Jun 1 2016
That 0 width/height definitely won't happen anymore. Fingers crossed? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyquist@chromium.org
, May 26 2016