Issue metadata
Sign in to add a comment
|
font color on inactive incognito tabs too light
Reported by
pdk...@gmail.com,
May 26 2016
|
||||||||||||||||||||||||||
Issue descriptionChrome Version : 51.0.2704.63 OS Version: Ubuntu 14.04 Poor contrast. Please compare to pre-M51.
,
May 27 2016
Re-opening for now for visibility. Is there an existing bug and/or a link to an a11y review that approved this contrast change? Subjectively, the contrast ratio looks really low to me on my monitor.
,
May 27 2016
Just want to add this only affects GTK+, which is the default theme on Ubuntu.
,
May 31 2016
I have three chrome:// pages bookmarked (bookmarks,settings,extensions) in between the Spaces and My Saves icons. They are almost invisible. See attached screenshots. Google Chrome 52.0.2743.0 (Official Build) dev (32-bit) Revision 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} Platform 8350.2.0 (Official Build) dev-channel veyron_minnie
,
May 31 2016
Re: #4. Thanks for submitting, it should be in a separate bug however. Created https://bugs.chromium.org/p/chromium/issues/detail?id=616131
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2016
,
Oct 11 2016
In 54.0.2840.50 this is worse yet.
,
Mar 5 2017
This bug should be un-merged, as the other bug is very different. Problem is still in M57.
,
Mar 6 2017
I'm not actually convinced the bug is different. I think both are about alpha-blending of background tabs.
,
Jun 13 2017
This is yet slighlty worse in M60.
,
Jun 13 2017
The screenshot in comment 11 definitely seems too low-contrast to me. I don't know what the status is here, whether this is Linux-specific, or whether the dupe to bug 615179 was correct. But if this doesn't get reopened nothing will happen, and I feel like something needs to happen.
,
Jun 13 2017
​Thanks for reopening. I think the recent regression might've been caused by the switch from GTK2 to GTK3 in M59. (I've skipped it, so don't know.)
,
Jul 14 2017
This works, but the actual problem is elsewhere.
diff --git a/chrome/browser/ui/libgtkui/gtk_ui.cc b/chrome/browser/ui/libgtkui/gtk_ui.cc
index 7df1d0c..1ea8a62 100644
--- a/chrome/browser/ui/libgtkui/gtk_ui.cc
+++ b/chrome/browser/ui/libgtkui/gtk_ui.cc
@@ -876,7 +876,7 @@ void GtkUi::LoadGtkValues() {
colors_[ThemeProperties::COLOR_TAB_TEXT] = tab_text_color;
colors_[ThemeProperties::COLOR_BOOKMARK_TEXT] = tab_text_color;
colors_[ThemeProperties::COLOR_BACKGROUND_TAB_TEXT] =
- color_utils::BlendTowardOppositeLuma(tab_text_color, 50);
+ color_utils::BlendTowardOppositeLuma(tab_text_color, 25);
SkColor location_bar_border = GetBorderColor("GtkEntry#entry");
if (SkColorGetA(location_bar_border))
,
Jul 16
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 16
I suspect this is better in Refresh.
,
Sep 7
Thanks @pkasting, this is much, much better.
,
Oct 20
Indeed it is. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, May 26 2016Components: UI>Browser>TabStrip UI>Browser>Incognito
Labels: -Type-Bug -Pri-3 M-52 Proj-MaterialDesign-NativeUI OS-Chrome OS-Windows Pri-2 Type-Bug-Regression
Owner: sgabr...@chromium.org
Status: WontFix (was: Unconfirmed)