New issue
Advanced search Search tips

Issue 615181 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 615179
Owner: ----
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression
Team-Accessibility

Blocking:
issue 501377
issue 505805



Sign in to add a comment

font color on inactive incognito tabs too light

Reported by pdk...@gmail.com, May 26 2016

Issue description

Chrome Version       : 51.0.2704.63
OS Version: Ubuntu 14.04

Poor contrast. Please compare to pre-M51.


 
Blocking: 501377 505805
Components: UI>Browser>TabStrip UI>Browser>Incognito
Labels: -Type-Bug -Pri-3 M-52 Proj-MaterialDesign-NativeUI OS-Chrome OS-Windows Pri-2 Type-Bug-Regression
Owner: sgabr...@chromium.org
Status: WontFix (was: Unconfirmed)
The difference in contrast seems pretty small to me.

WontFixing, but ->sgabriel in case he wants to reopen.
Cc: lpalmaro@chromium.org
Status: Assigned (was: WontFix)
Re-opening for now for visibility. Is there an existing bug and/or a link to an a11y review that approved this contrast change?

Subjectively, the contrast ratio looks really low to me on my monitor.

Comment 3 by pdk...@gmail.com, May 27 2016

Just want to add this only affects GTK+, which is the default theme on Ubuntu.

Comment 4 by dymp...@gmail.com, May 31 2016

I have three chrome:// pages bookmarked (bookmarks,settings,extensions) in between the Spaces and My Saves icons. They are almost invisible. See attached screenshots.

Google Chrome	52.0.2743.0 (Official Build) dev (32-bit)
Revision	2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Platform	8350.2.0 (Official Build) dev-channel veyron_minnie
Screenshot 2016-05-31 at 12.27.02 PM.png
14.3 KB View Download
Screenshot 2016-05-31 at 12.31.22 PM.png
9.6 KB View Download
Re: #4. Thanks for submitting, it should be in a separate bug however. Created https://bugs.chromium.org/p/chromium/issues/detail?id=616131
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 615179
Status: Duplicate (was: Assigned)

Comment 8 by pdk...@gmail.com, Oct 11 2016

In 54.0.2840.50 this is worse yet.


Comment 9 by pdk...@gmail.com, Mar 5 2017

This bug should be un-merged, as the other bug is very different. Problem is still in M57.
I'm not actually convinced the bug is different.  I think both are about alpha-blending of background tabs.

Comment 11 by pdk...@gmail.com, Jun 13 2017

This is yet slighlty worse in M60.


Components: UI>Accessibility
Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Duplicate)
The screenshot in comment 11 definitely seems too low-contrast to me.

I don't know what the status is here, whether this is Linux-specific, or whether the dupe to  bug 615179  was correct.  But if this doesn't get reopened nothing will happen, and I feel like something needs to happen.

Comment 13 by pdk...@gmail.com, Jun 13 2017

​Thanks for reopening. I think the recent regression might've been caused
by the switch from GTK2 to GTK3 in M59. (I've skipped it, so don't know.)

Comment 14 by pdk...@gmail.com, Jul 14 2017

This works, but the actual problem is elsewhere.

diff --git a/chrome/browser/ui/libgtkui/gtk_ui.cc b/chrome/browser/ui/libgtkui/gtk_ui.cc
index 7df1d0c..1ea8a62 100644
--- a/chrome/browser/ui/libgtkui/gtk_ui.cc
+++ b/chrome/browser/ui/libgtkui/gtk_ui.cc
@@ -876,7 +876,7 @@ void GtkUi::LoadGtkValues() {
   colors_[ThemeProperties::COLOR_TAB_TEXT] = tab_text_color;
   colors_[ThemeProperties::COLOR_BOOKMARK_TEXT] = tab_text_color;
   colors_[ThemeProperties::COLOR_BACKGROUND_TAB_TEXT] =
-      color_utils::BlendTowardOppositeLuma(tab_text_color, 50);
+      color_utils::BlendTowardOppositeLuma(tab_text_color, 25);
 
   SkColor location_bar_border = GetBorderColor("GtkEntry#entry");
   if (SkColorGetA(location_bar_border))

Project Member

Comment 15 by sheriffbot@chromium.org, Jul 16

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I suspect this is better in Refresh.
Status: Fixed (was: Untriaged)
Thanks @pkasting, this is much, much better.
Indeed it is.

Sign in to add a comment