New issue
Advanced search Search tips

Issue 615155 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Aug 2016
Cc:
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 629244
issue 629248
issue 629250
issue 629252
issue 629254
issue 629255
issue 629257
issue 629990
issue 631215
issue 631216
issue 632071
issue 633323
issue 633324
issue 635638
issue 636010


Sign in to add a comment

Convert shelf to use ash WmWindow types

Project Member Reported by jamescook@chromium.org, May 26 2016 
This is a tracking bug for making the ash::Shelf* classes use ash::wm::WmWindow instead of aura::Window directly.

For mash, we're starting to collapse the window manager (desktop_wm) and system UI (ash_sysui) into a single process/service. The window manager bits manipulate mus windows, via a wrapper class ash::wm::WmWindow.

In order to make the shelf work in this environment it will need to avoid direct access to aura::Window and use the wrappers instead.

I suspect this will take many CLs.
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e

commit 6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e
Author: jamescook <jamescook@chromium.org>
Date: Fri May 27 06:15:54 2016

mash: Convert shelf to wm::WmWindow types, part 1

Shelf and its dependencies need to use wm::WmWindow so they can run both in
classic ash and mash (with combined desktop_wm / ash_sysui).

* Eliminate ash::RootWindowController use in ShelfWidget and StatusAreaWidget
* Convert aura::Window use in shelf and status header files to wm::WmWindow
* Eliminate unnecessary ShelfWidget::container_window_

No functional changes.

BUG= 615155 
TEST=existing ash_unittests

Review-Url: https://codereview.chromium.org/2015043002
Cr-Commit-Position: refs/heads/master@{#396405}

[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/root_window_controller.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/root_window_controller.h
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/shelf/shelf_widget.h
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/shell.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/shell/window_watcher.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/system/status_area_widget.cc
[modify] https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e/ash/system/status_area_widget.h

Comment 2 by jamescook@chromium.org, Jun 2 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2

commit 8a10a2b2511632f20fc822b2ac4bd78d0c2032d2
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 03 02:35:27 2016

ash: Remove aura dependencies from ash/system/web_notification

* Switch to common wm:WmWindow types.
* Convert unit tests to use views::Widget instead of aura::Window

No functional changes.

TODO: Figure out how to set window parents in ui/message_center without
using aura.

BUG= 615155 
TEST=existing ash_unittests

Review-Url: https://codereview.chromium.org/2033833002
Cr-Commit-Position: refs/heads/master@{#397587}

[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/shelf/shelf.cc
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/shelf/shelf.h
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2/ash/system/web_notification/web_notification_tray_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b474d6a05616dbb12d788430075285bf7f11810

commit 1b474d6a05616dbb12d788430075285bf7f11810
Author: jamescook <jamescook@chromium.org>
Date: Sat Jun 04 05:56:00 2016

mash: Move ash/common/wm/shelf to ash/common/shelf

* Collapse wm_shelf_constants.h with shelf_constants.h
* Start collapsing wm_shelf_types.h with shelf_types.h. This will be done in
two steps to preserve rename history.
* Move the other files as-is

No functional changes.

BUG= 615155 
TEST=compiles

Review-Url: https://codereview.chromium.org/2036353002
Cr-Commit-Position: refs/heads/master@{#397907}

[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/ash.gyp
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/aura/wm_shelf_aura.h
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/shelf_constants.cc
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/shelf_constants.h
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/shelf_types.h
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/wm_shelf.h
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/wm_shelf_observer.h
[add] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/wm_shelf_util.cc
[rename] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/shelf/wm_shelf_util.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/panels/panel_window_resizer.cc
[delete] https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5/ash/common/wm/shelf/wm_shelf_constants.cc
[delete] https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5/ash/common/wm/shelf/wm_shelf_constants.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm/shelf/wm_shelf_types.h
[delete] https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5/ash/common/wm/shelf/wm_shelf_util.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/mus/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/root_window_controller.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/root_window_controller.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/app_list_button.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/overflow_button.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/overflow_button.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_alignment_menu.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_button.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_item_types.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_layout_manager_observer.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_locking_manager.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_locking_manager.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_locking_manager_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_navigator.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_util.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_util.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_view.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_widget.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shell.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/shell/context_menu.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/cast/tray_cast.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/network/tray_network.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/network/tray_vpn.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/power/tray_power.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/date/tray_date.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/date/tray_date.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/status_area_widget.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/status_area_widget.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/status_area_widget_delegate.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/system_tray.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/system_tray.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/system_tray_item.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/tray/tray_utils.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/user/tray_user.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/user/tray_user.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/user/tray_user_separator.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/sysui/context_menu_mus.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/sysui/shelf_delegate_mus.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/window_animations.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/chromeos/first_run/steps/tray_step.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/chrome_launcher_prefs.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
[modify] https://crrev.com/1b474d6a05616dbb12d788430075285bf7f11810/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6ed82face2a9d329cd9f6309266958a3948b3f

commit be6ed82face2a9d329cd9f6309266958a3948b3f
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 06 20:08:55 2016

mash: Move WmShelfAura ownership to RootWindowController and init it earlier

This will allow it to be used in status tray initialization code. In particular:
* It can wrap actions handled by ShelfWidget and ShelfLayoutManager
(e.g. GetAutoHideState)
* It can have observers similar to ShelfLayoutManagerObserver
(OnAutoHideStateChanged)

It's also more similar to how ash::mus::RootWindowController owns WmShelfMus.

BUG= 615155 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2041583004
Cr-Commit-Position: refs/heads/master@{#398105}

[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/common/wm/workspace/workspace_layout_manager_delegate.h
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/root_window_controller.cc
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/root_window_controller.h
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/shelf/shelf.cc
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/shelf/shelf.h
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f/ash/shelf/shelf_widget.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e

commit ec04cc3ca7ac5354dd69fa39f149e92e6c19434e
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 07 00:52:45 2016

mash: Move shelf model and item classes to ash/common/shelf

ShelfModel, ShelfItemDelegate and ShelfItemDelegate have no dependencies on
ash::Shell, ash::RootWindowController or aura::Window so they can be moved
as-is.

No functional changes.

BUG= 615155 
TEST=compiles

Review-Url: https://codereview.chromium.org/2046513003
Cr-Commit-Position: refs/heads/master@{#398178}

[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/ash.gyp
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_item_delegate.h
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_item_delegate_manager.cc
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_item_delegate_manager.h
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_item_types.cc
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_item_types.h
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_model.cc
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_model.h
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_model_observer.h
[rename] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/common/shelf/shelf_model_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/app_list_button.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/app_list_shelf_item_delegate.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/app_list_shelf_item_delegate.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_button_pressed_metric_tracker.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_delegate.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_navigator.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_navigator_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_util.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_view.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_view.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_window_watcher_item_delegate.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shell.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shell/window_watcher.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shell/window_watcher.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/shell/window_watcher_shelf_item_delegate.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/sysui/shelf_delegate_mus.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/test/shelf_item_delegate_manager_test_api.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/test/shelf_view_test_api.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/test/test_shelf_delegate.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/test/test_shelf_item_delegate.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e/chrome/browser/ui/ash/launcher/launcher_item_controller.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26db34d5889988990938d46d99a02859481ad539

commit 26db34d5889988990938d46d99a02859481ad539
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 07 18:25:38 2016

mash: Migrate SessionStateDelegate interface to wm common types

Not much changed here, as the only interesting implementation is in chrome.

BUG= 615155 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2042333002
Cr-Commit-Position: refs/heads/master@{#398349}

[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/session/session_state_delegate.h
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/test/test_session_state_delegate.cc
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/ash/test/test_session_state_delegate.h
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/chrome/browser/ui/ash/session_state_delegate_chromeos.cc
[modify] https://crrev.com/26db34d5889988990938d46d99a02859481ad539/chrome/browser/ui/ash/session_state_delegate_chromeos.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b624c5a101e9440b71ad963b1d21ebf56f185eb

commit 2b624c5a101e9440b71ad963b1d21ebf56f185eb
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 08 01:34:02 2016

mash: Move //ash/session to //ash/common/session

* Add GetSessionStateDelegate() accessor to WmShell
* Remove existing WmShell wrapper functions for SessionStateDelegate
* Add a stub SessionStateDelegate to //ash/mus
* Move the files
* Clean up some #includes along the way

BUG= 615155 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2041233004
Cr-Commit-Position: refs/heads/master@{#398451}

[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/ash.gyp
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/aura/wm_shell_aura.h
[rename] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/session/session_state_delegate.cc
[rename] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/session/session_state_delegate.h
[add] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/session/session_state_observer.cc
[rename] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/session/session_state_observer.h
[rename] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/session/session_types.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/wm/container_finder.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/common/wm_shell.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/content/shell_content_state.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/desktop_background/desktop_background_view.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/media_delegate.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/mus/BUILD.gn
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/root_window_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/root_window_controller_unittest.cc
[delete] https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190/ash/session/session_state_observer.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_locking_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_locking_manager.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_locking_manager_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell/app_list.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell/lock_view.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/shell_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/chromeos/power/power_event_observer.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/chromeos/session/logout_confirmation_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/date/date_default_view.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/tray/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/login_status.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/tray_user.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/tray_user.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/tray_user_separator.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/user_card_view.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/user_view.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/system/user/user_view.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/test/shell_test_api.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/test/test_session_state_delegate.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/event_client_impl.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/power_button_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/window_cycle_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/chromeos/login/session_login_browsertest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/memory/tab_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/chrome_shell_content_state_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/session_state_delegate_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/session_state_delegate_chromeos.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/session_util.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/views/frame/browser_frame.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/views/frame/system_menu_model_builder.cc
[modify] https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da53c1490a2ec1a040cefb23492cbc68d873162c

commit da53c1490a2ec1a040cefb23492cbc68d873162c
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 08 23:38:56 2016

mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG= 615155 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2046843005
Cr-Commit-Position: refs/heads/master@{#398735}

[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/common/wm/wm_user_metrics_action.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/metrics/user_metrics_recorder.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/root_window_controller.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf_alignment_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf_alignment_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf_view.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf_view.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shell/context_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shell/context_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/shell_delegate.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/sysui/context_menu_mus.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/sysui/context_menu_mus.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/test/shelf_test_api.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/ash/test/test_shell_delegate.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdbbc06a9ef355c904ccc62578ab1015e31aaf49

commit bdbbc06a9ef355c904ccc62578ab1015e31aaf49
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 09 00:47:24 2016

mash: Move shelf menu code to //ash/common/shelf

It no longer has non-common dependencies.

I'll TBR since it's a purely mechanical file move.

BUG= 615155 
TEST=compiles
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2046563012
Cr-Commit-Position: refs/heads/master@{#398750}

[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/ash.gyp
[rename] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/common/shelf/shelf_alignment_menu.cc
[rename] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/common/shelf/shelf_alignment_menu.h
[rename] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/common/shelf/shelf_menu_model.h
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/shelf/shelf_view.cc
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/shell/context_menu.h
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/sysui/context_menu_mus.h
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/ash/sysui/shelf_delegate_mus.cc
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h
[modify] https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49/chrome/browser/ui/ash/launcher/launcher_context_menu.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7

commit 2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 09 20:10:07 2016

mash: Move SystemTrayDelegate and dependencies to //ash/common

These are dependencies of TrayUpdate, which I'm in the process of moving.

Creates a new directory for update-related code, //ash/common/system/update.

This is mostly a mechanical move:
* move_source_file.py ash/system/tray/system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/user/update_observer.h ash/common/system/update/
* move_source_file.py ash/volume_control_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.cc ash/common/system/

Removes a couple of unnecessary includes along the way.

BUG= 615155 
TEST=compiles
TBR=sky@chromium.org for mechanical changes in //chrome

Review-Url: https://codereview.chromium.org/2056823002
Cr-Commit-Position: refs/heads/master@{#398990}

[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/ash.gyp
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/networking_config_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/networking_config_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/default_system_tray_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/default_system_tray_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/system_tray_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/system_tray_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/update/update_observer.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/volume_control_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/root_window_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shell.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/brightness/tray_brightness_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/power/dual_role_notification.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/date/date_default_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/date/date_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/status_area_widget.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_update.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_update.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/tray_user.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/user_card_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/user_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/test_system_tray_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/test_volume_control_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/login/signin/merge_session_load_page.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/power/power_button_observer.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/networking_config_delegate_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_utils.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/volume_controller_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/vpn_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12aaeb94fc430796833936016bbc1f29c23ee38f

commit 12aaeb94fc430796833936016bbc1f29c23ee38f
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 09 22:04:54 2016

mash: Move tray_constants.h and FixedSizedImageView to //ash/common

These are dependencies of TrayUpdate, which I am moving to //ash/common

TBR because this is a purely mechanical move:
* move_source_file.py ash/system/tray/tray_constants.h ash/common/system/tray/
* move_source_file.py ash/system/tray/tray_constants.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.h ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.cc ash/common/system/tray/

BUG= 615155 
TEST=compiles
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2056683003
Cr-Commit-Position: refs/heads/master@{#399030}

[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/ash.gyp
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/fixed_sized_image_view.cc
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/fixed_sized_image_view.h
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/tray_constants.cc
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/audio/volume_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/label_tray_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/power/power_status_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/date/date_default_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/date/date_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/special_popup_row.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/throbber_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_bar_button_with_title.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_event_filter.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_item_more.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_notification_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_popup_item_container.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray_accessibility.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray_update.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/button_from_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/tray_user.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/user_card_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/user_view.h
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/web_notification/web_notification_tray.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18

commit fd4ba1d215ee2450d23ac71a1d3728d4bb21de18
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 10 04:38:17 2016

mash: Convert ash::ShellDelegate from aura::Window to WmWindow

Also remove unnecessary shell.h include from shell_delegate.h and clean up
includes elsewhere.

BUG= 615155 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2055053002
Cr-Commit-Position: refs/heads/master@{#399097}

[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/common/wm_shell.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/system/user/tray_user.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/test/test_shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/session_util.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443e42d71ea1b9836c434c661cb2cd2517d413d4

commit 443e42d71ea1b9836c434c661cb2cd2517d413d4
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 10 21:44:46 2016

mash: Move SystemTrayDelegate ownership to WmShell

This makes it possible to use inside //ash/common.

(SystemTrayDelegate is a dependency of TrayUpdate, which I'm in the process
of moving to //ash/common.)

* Make WmShell non-pure-virtual
* Fix now-unneeded includes of shell.h
* Fix some unnecessary ash:: qualifiers along the way

BUG= 615155 
TEST=existing ash_unittests, chrome unit_tests and browser_tests
TBR=sky@chromium.org for mechanical changes to //chrome/browser

Review-Url: https://codereview.chromium.org/2058173002
Cr-Commit-Position: refs/heads/master@{#399277}

[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/common/wm_shell.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/common/wm_shell.h
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shell.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shell.h
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/power/dual_role_notification.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/supervised/tray_supervised_user_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_display_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/date/date_default_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/date/date_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/status_area_widget.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray/system_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray_accessibility.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray_update.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/tray_user.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/user_card_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/user_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/ash_test_base.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/power/power_button_observer.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/vpn_delegate_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5

commit 9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 17:24:48 2016

mash: Introduce WmSystemTrayNotifier for //ash/common

SystemTrayNotifier is a dependency of TrayUpdate, which I am trying to move
to //ash/common.

SystemTrayNotifier has a large number of dependencies, so split out a new
version called WmSystemTrayNotifier where we can port dependencies one by one.

Move update notifications to WmSystemTrayObserver.

BUG= 615155 
TEST=existing ash_unittests, specifically TrayUpdateTest

Review-Url: https://codereview.chromium.org/2060633002
Cr-Commit-Position: refs/heads/master@{#399473}

[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/ash.gyp
[add] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/system/tray/wm_system_tray_notifier.cc
[add] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/wm_shell.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/wm_shell.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray_update.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray_update_unittest.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7

commit 2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 09 20:10:07 2016

mash: Move SystemTrayDelegate and dependencies to //ash/common

These are dependencies of TrayUpdate, which I'm in the process of moving.

Creates a new directory for update-related code, //ash/common/system/update.

This is mostly a mechanical move:
* move_source_file.py ash/system/tray/system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/user/update_observer.h ash/common/system/update/
* move_source_file.py ash/volume_control_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.cc ash/common/system/

Removes a couple of unnecessary includes along the way.

BUG= 615155 
TEST=compiles
TBR=sky@chromium.org for mechanical changes in //chrome

Review-Url: https://codereview.chromium.org/2056823002
Cr-Commit-Position: refs/heads/master@{#398990}

[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/ash.gyp
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/networking_config_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/networking_config_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/default_system_tray_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/default_system_tray_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/system_tray_delegate.cc
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/tray/system_tray_delegate.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/update/update_observer.h
[rename] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/common/system/volume_control_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/root_window_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shell.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/brightness/tray_brightness_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/power/dual_role_notification.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/date/date_default_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/date/date_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/status_area_widget.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_update.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/tray_update.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/tray_user.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/user_card_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/system/user/user_view.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/test_system_tray_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/test_volume_control_delegate.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/login/signin/merge_session_load_page.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/power/power_button_observer.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/networking_config_delegate_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_delegate_utils.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/volume_controller_chromeos.h
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/ash/vpn_delegate_chromeos.cc
[modify] https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12aaeb94fc430796833936016bbc1f29c23ee38f

commit 12aaeb94fc430796833936016bbc1f29c23ee38f
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 09 22:04:54 2016

mash: Move tray_constants.h and FixedSizedImageView to //ash/common

These are dependencies of TrayUpdate, which I am moving to //ash/common

TBR because this is a purely mechanical move:
* move_source_file.py ash/system/tray/tray_constants.h ash/common/system/tray/
* move_source_file.py ash/system/tray/tray_constants.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.h ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.cc ash/common/system/tray/

BUG= 615155 
TEST=compiles
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2056683003
Cr-Commit-Position: refs/heads/master@{#399030}

[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/ash.gyp
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/fixed_sized_image_view.cc
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/fixed_sized_image_view.h
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/tray_constants.cc
[rename] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/audio/volume_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/label_tray_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/power/power_status_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/date/date_default_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/date/date_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/special_popup_row.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/throbber_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_bar_button_with_title.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_event_filter.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_item_more.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_notification_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_popup_item_container.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray_accessibility.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/tray_update.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/button_from_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/tray_user.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/user_card_view.cc
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/user/user_view.h
[modify] https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f/ash/system/web_notification/web_notification_tray.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18

commit fd4ba1d215ee2450d23ac71a1d3728d4bb21de18
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 10 04:38:17 2016

mash: Convert ash::ShellDelegate from aura::Window to WmWindow

Also remove unnecessary shell.h include from shell_delegate.h and clean up
includes elsewhere.

BUG= 615155 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2055053002
Cr-Commit-Position: refs/heads/master@{#399097}

[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/common/wm_shell.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/system/user/tray_user.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/ash/test/test_shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18/chrome/browser/ui/ash/session_util.h
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443e42d71ea1b9836c434c661cb2cd2517d413d4

commit 443e42d71ea1b9836c434c661cb2cd2517d413d4
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 10 21:44:46 2016

mash: Move SystemTrayDelegate ownership to WmShell

This makes it possible to use inside //ash/common.

(SystemTrayDelegate is a dependency of TrayUpdate, which I'm in the process
of moving to //ash/common.)

* Make WmShell non-pure-virtual
* Fix now-unneeded includes of shell.h
* Fix some unnecessary ash:: qualifiers along the way

BUG= 615155 
TEST=existing ash_unittests, chrome unit_tests and browser_tests
TBR=sky@chromium.org for mechanical changes to //chrome/browser

Review-Url: https://codereview.chromium.org/2058173002
Cr-Commit-Position: refs/heads/master@{#399277}

[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/common/wm_shell.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/common/wm_shell.h
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shell.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/shell.h
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/power/dual_role_notification.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/supervised/tray_supervised_user_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_display_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/date/date_default_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/date/date_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/status_area_widget.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray/system_tray.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray_accessibility.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/tray_update.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/tray_user.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/user_card_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/user/user_view.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/ash_test_base.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/power/power_button_observer.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/ash/vpn_delegate_chromeos.cc
[modify] https://crrev.com/443e42d71ea1b9836c434c661cb2cd2517d413d4/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5

commit 9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 17:24:48 2016

mash: Introduce WmSystemTrayNotifier for //ash/common

SystemTrayNotifier is a dependency of TrayUpdate, which I am trying to move
to //ash/common.

SystemTrayNotifier has a large number of dependencies, so split out a new
version called WmSystemTrayNotifier where we can port dependencies one by one.

Move update notifications to WmSystemTrayObserver.

BUG= 615155 
TEST=existing ash_unittests, specifically TrayUpdateTest

Review-Url: https://codereview.chromium.org/2060633002
Cr-Commit-Position: refs/heads/master@{#399473}

[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/ash.gyp
[add] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/system/tray/wm_system_tray_notifier.cc
[add] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/wm_shell.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/common/wm_shell.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray_update.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/ash/system/tray_update_unittest.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

Comment 22 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629244

Comment 23 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629248

Comment 24 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629250

Comment 25 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629252

Comment 26 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629254

Comment 27 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629255

Comment 28 by jamescook@chromium.org, Jul 18 2016

Blockedon: 629257

Comment 29 by jamescook@chromium.org, Jul 20 2016

Blockedon: 629990

Comment 31 by jamescook@chromium.org, Jul 25 2016

Blockedon: 631215

Comment 32 by jamescook@chromium.org, Jul 25 2016

Blockedon: 631216

Comment 33 by jamescook@chromium.org, Jul 27 2016

Blockedon: 632071

Comment 35 by msw@chromium.org, Jul 29 2016 

Before/after images for WIP CL https://codereview.chromium.org/2190773003/ (patch set 6):
shelf_dimmer_before.png
72.4 KB View Download
shelf_dimmer_after_d.png
70.3 KB View Download

Comment 36 by jamescook@chromium.org, Aug 1 2016

Blockedon: 633323

Comment 37 by jamescook@chromium.org, Aug 1 2016

Blockedon: 633324
Project Member

Comment 38 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36af7b5e3aa2816d67e720bfd633029b82a724f1

commit 36af7b5e3aa2816d67e720bfd633029b82a724f1
Author: msw <msw@chromium.org>
Date: Wed Aug 03 17:31:11 2016

mash: Move the shelf DimmerView out of shelf_widget.cc.

Move DimmerView to ash/shelf/dimmer_view.[h|cc].
Add a static Create helper for View&Widget creation.

Convert aura::WindowOberserver->WmWindowObserver.
(and move observation from ShelfWidget to DimmerView)

Nix ShelfWidget's pointer to the DimmerView's widget.
Make the dimmer widget be owned by its native widget.

Pass WmShelf not ShelfWidget to DimmerView.
Undim on ShelfWidget::Shutdown.

BUG= 615155 
TEST=Automated tests; no Chrome OS shelf dimmer changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2204843003
Cr-Commit-Position: refs/heads/master@{#409558}

[modify] https://crrev.com/36af7b5e3aa2816d67e720bfd633029b82a724f1/ash/ash.gyp
[add] https://crrev.com/36af7b5e3aa2816d67e720bfd633029b82a724f1/ash/shelf/dimmer_view.cc
[add] https://crrev.com/36af7b5e3aa2816d67e720bfd633029b82a724f1/ash/shelf/dimmer_view.h
[modify] https://crrev.com/36af7b5e3aa2816d67e720bfd633029b82a724f1/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/36af7b5e3aa2816d67e720bfd633029b82a724f1/ash/shelf/shelf_widget.h
Project Member

Comment 39 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105

commit 757a8f0c8a59d4dd16ad8821a19fa2f1609c0105
Author: msw <msw@chromium.org>
Date: Wed Aug 03 23:59:42 2016

mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG= 615155 , 629257 
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2211463002
Cr-Commit-Position: refs/heads/master@{#409671}

[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/ash.gyp
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/aura/wm_window_aura.h
[rename] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/shelf/shelf_window_watcher.cc
[rename] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/shelf/shelf_window_watcher.h
[rename] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/shelf/shelf_window_watcher_item_delegate.cc
[rename] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/shelf/shelf_window_watcher_item_delegate.h
[add] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/wm_shell.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/wm_shell.h
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/common/wm_window.h
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/mus/bridge/wm_window_mus.h
[delete] https://crrev.com/96b9de712a092e59ccc38336c6f3fb3c14630399/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/shell.cc
[modify] https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105/ash/shell.h
Project Member

Comment 41 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45754f1c35ffffab564b60c87e299e28e0951d5f

commit 45754f1c35ffffab564b60c87e299e28e0951d5f
Author: msw <msw@chromium.org>
Date: Fri Aug 05 02:32:24 2016

mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG= 615155 
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2209803004
Cr-Commit-Position: refs/heads/master@{#409970}

[modify] https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f/ash/ash.gyp
[modify] https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f/ash/shelf/shelf_widget.h
[add] https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f/ash/shelf/shelf_window_targeter.cc
[add] https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f/ash/shelf/shelf_window_targeter.h
Project Member

Comment 42 by bugdroid1@chromium.org, Aug 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7626933226e5e892cbaf50590f0ca1367cf0d0e0

commit 7626933226e5e892cbaf50590f0ca1367cf0d0e0
Author: msw <msw@chromium.org>
Date: Sat Aug 06 02:25:48 2016

mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG= 615155 , 622480 
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2215223004
Cr-Commit-Position: refs/heads/master@{#410253}

[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm/wm_screen_util.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm/wm_screen_util.h
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm_shell.h
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util.h
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util_unittest.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/wm/lock_window_state.cc

Comment 43 by jamescook@chromium.org, Aug 8 2016

Blockedon: 635638
Project Member

Comment 44 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad28b255b026ddb41fab655e34d4b22d4e50fea2

commit ad28b255b026ddb41fab655e34d4b22d4e50fea2
Author: msw <msw@chromium.org>
Date: Tue Aug 09 02:42:07 2016

mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG= 615155 
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2225083003
Cr-Commit-Position: refs/heads/master@{#410548}

[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/common/wm_shell.h
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/shell.h
[modify] https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2/ash/wm/drag_window_resizer_unittest.cc

Comment 45 by jamescook@chromium.org, Aug 9 2016

Blockedon: 636010
Project Member

Comment 46 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752e8df8664956328150560c93c13e3c00a6987f

commit 752e8df8664956328150560c93c13e3c00a6987f
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 09 19:54:39 2016

ash: Move ShelfWindowTargeter construction from ShelfWidget to RootWindowController

This eliminates aura::Window dependencies from ShelfWidget, which we need to do
to get it running in mus/mash.

mus will need a different implementation of this feature.

BUG= 615155 , 636010 
TEST=existing ash_unittests for ShelfWidget

Review-Url: https://codereview.chromium.org/2222093003
Cr-Commit-Position: refs/heads/master@{#410781}

[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/root_window_controller.cc
[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/shelf/shelf_widget.cc
Project Member

Comment 47 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2dd2245e3707d5ff18b3186192f00253c04598f

commit e2dd2245e3707d5ff18b3186192f00253c04598f
Author: msw <msw@chromium.org>
Date: Tue Aug 09 20:53:31 2016

mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG= 615155 , 621112 , 631216 
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2227143003
Cr-Commit-Position: refs/heads/master@{#410813}

[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/common/system/status_area_widget.cc
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/common/system/status_area_widget.h
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f/ash/shelf/shelf_widget.h
Project Member

Comment 48 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b

commit 896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b
Author: jamescook <jamescook@chromium.org>
Date: Wed Aug 10 00:30:26 2016

mash shelf: Don't create shelf DimmerView in ShelfWidget on mus

This removes another aura dependency from ShelfWidget.

* Introduce a pure-virtual interface for the DimmerView.
* Delegate creation of the WmDimmerView out via WmShelf.
* Return a null WmDimmerView on mus, indicating dimming is not supported.
* Clean up some |shelf| vs. |shelf_widget| confusion in ShelfWidget.

BUG= 615155 
TEST=existing ash_unittests

Review-Url: https://codereview.chromium.org/2235513002
Cr-Commit-Position: refs/heads/master@{#410896}

[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/aura/wm_shelf_aura.h
[add] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/common/shelf/wm_dimmer_view.h
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/shelf/dimmer_view.cc
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/shelf/dimmer_view.h
[modify] https://crrev.com/896df1b1c68d4463c8ff5f05ff2c8b60a7d2e52b/ash/shelf/shelf_widget.cc
Project Member

Comment 49 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5513e3d979bd1eecb221405a1fae007f38ae3c2

commit c5513e3d979bd1eecb221405a1fae007f38ae3c2
Author: jamescook <jamescook@chromium.org>
Date: Wed Aug 10 15:42:32 2016

Show the status area widget in mash

This code will need to change when ShelfLayoutManager is working in mash, but
for now it gets something on the screen.

BUG= 615155 , 621112 
TEST=none

Review-Url: https://codereview.chromium.org/2230083002
Cr-Commit-Position: refs/heads/master@{#411046}

[modify] https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2/ash/mus/root_window_controller.cc
Project Member

Comment 50 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7025b343bb1a6bdf97242a09c10e6b0633a140f4

commit 7025b343bb1a6bdf97242a09c10e6b0633a140f4
Author: jamescook <jamescook@chromium.org>
Date: Wed Aug 10 16:29:08 2016

Revert of Show the status area widget in mash (patchset #1 id:1 of https://codereview.chromium.org/2230083002/ )

Reason for revert:
This doesn't work due to ash_sysui no longer running https://codereview.chromium.org/2235493002/. I'm going to revert and land a patch that works.

Original issue's description:
> Show the status area widget in mash
>
> This code will need to change when ShelfLayoutManager is working in mash, but
> for now it gets something on the screen.
>
> BUG= 615155 , 621112 
> TEST=none
>
> Committed: https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2
> Cr-Commit-Position: refs/heads/master@{#411046}

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615155 , 621112 

Review-Url: https://codereview.chromium.org/2233753003
Cr-Commit-Position: refs/heads/master@{#411051}

[modify] https://crrev.com/7025b343bb1a6bdf97242a09c10e6b0633a140f4/ash/mus/root_window_controller.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fabdd65c794131e3abf9093b4a6f9eb256a4615

commit 5fabdd65c794131e3abf9093b4a6f9eb256a4615
Author: msw <msw@chromium.org>
Date: Thu Aug 11 01:48:30 2016

mash: Remove WorkspaceLayoutManagerDelegate.

Call WmShelf::UpdateVisibilityState directly.
Move and call WmShell::NotifyFullscreenStateChanged.

Check for the default container instead of |delegate|.
This should mirror existing always-on-top behavior.
See related: https://codereview.chromium.org/1841803002

Nix WmRootWindowControllerObserver::OnFullscreenStateChanged.
(use the original ShellObserver observer pattern instead)

BUG= 615155 
TEST=Automated; no cros resgressions.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2234033002
Cr-Commit-Position: refs/heads/master@{#411222}

[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/ash.gyp
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm/always_on_top_controller.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm/workspace/workspace_layout_manager.h
[delete] https://crrev.com/2c4d5f592e84033ef5079905810f335df497e24e/ash/common/wm/workspace/workspace_layout_manager_delegate.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm_root_window_controller_observer.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm_shell.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/common/wm_shell.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/mus/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/mus/root_window_controller.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/mus/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/root_window_controller.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/shell.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/shell.h
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/wm/workspace_controller.cc
[modify] https://crrev.com/5fabdd65c794131e3abf9093b4a6f9eb256a4615/ash/wm/workspace_controller.h
Project Member

Comment 52 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83d3bfb776904539c12d7cbf0644b0ba596378fd

commit 83d3bfb776904539c12d7cbf0644b0ba596378fd
Author: msw <msw@chromium.org>
Date: Thu Aug 11 02:57:40 2016

mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG= 615155 
TEST=Automated; no cros regressions.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2237613002
Cr-Commit-Position: refs/heads/master@{#411238}

[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/ash.gyp
[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/aura/wm_shelf_aura.h
[delete] https://crrev.com/b084e73aae95c6324c39ae87e74a5412b85df0d2/ash/shelf/shelf_bezel_event_filter.h
[rename] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/shelf/shelf_bezel_event_handler.cc
[add] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/shelf/shelf_bezel_event_handler.h
[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd/ash/wm/window_animations.h
Project Member

Comment 53 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ae2bba5625bc75256123ee8ee955ecc38db9e3

commit 65ae2bba5625bc75256123ee8ee955ecc38db9e3
Author: jamescook <jamescook@chromium.org>
Date: Thu Aug 11 22:44:36 2016

ash: Remove WmShelf::IsShowingOverflowBubble

It's no longer needed now that ShelfView has moved into //ash/common.

Just cleanup, no functional changes.

BUG= 615155 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2238903003
Cr-Commit-Position: refs/heads/master@{#411431}

[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/common/shelf/overflow_button.cc
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/common/shelf/overflow_button.h
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/common/shelf/shelf_view.h
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3/ash/shelf/shelf.h
Project Member

Comment 55 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3

commit 6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3
Author: msw <msw@chromium.org>
Date: Fri Aug 12 04:06:02 2016

mash: Partially migrate WorkspaceController to ash common.

Remove direct ShelfLayoutManager / WorkspaceController interaction.
(alleviate some shelf widget and layout manager dependencies)

Handle null WmWindowAura layout managers.
Null check WmRootWindowControllerAura::GetWorkspaceWindowState.
Move scale animation util to ash/common/wm/wm_window_animations.*
Define local kIntialAnimationDurationMS for WorkspaceController.

BUG= 615155 
TEST=Automated; no cros shelf or workspace regressions.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2243513004
Cr-Commit-Position: refs/heads/master@{#411547}

[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/ash.gyp
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/aura/wm_window_aura.cc
[add] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/common/wm/wm_window_animations.cc
[add] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/common/wm/wm_window_animations.h
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/root_window_controller.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/shelf/shelf_widget.h
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/wm/session_state_animator_impl.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/wm/window_animations.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/wm/window_animations.h
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/wm/workspace_controller.cc
[modify] https://crrev.com/6d9e0fd7c9a567eacc7c85bc0b57378aa237f2d3/ash/wm/workspace_controller.h
Project Member

Comment 56 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce

commit 61e1667efe869e8acb8bd72a4e7ad1a0f30236ce
Author: msw <msw@chromium.org>
Date: Fri Aug 12 16:36:58 2016

mash: Migrate Shelf aura::Window uses to WmWindow.

Convert remaining Shelf aura::Window parameters to WmWindow.
(TODO: move shelf files to eliminate internal aura::Window use)
Move shelf notify functions to WmShell. Update callers. Misc cleanup.

BUG= 615155 
TEST=Automated; no Chrome OS shelf regressions.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2237903003
Cr-Commit-Position: refs/heads/master@{#411673}

[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/common/wm_shell.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/common/wm_shell.h
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/root_window_controller.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shelf/shelf.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shelf/shelf.h
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shell.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/shell.h
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/wm/window_animations.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/ui/ash/shelf_browsertest.cc
[modify] https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
Project Member

Comment 57 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccb5d69efde4c915618f8334fa4a5231a09d3bb7

commit ccb5d69efde4c915618f8334fa4a5231a09d3bb7
Author: msw <msw@chromium.org>
Date: Wed Aug 17 20:37:48 2016

mash: Create and show a shelf in mash.

Allow mash to use the shelf, widget, and layout manager.
Delay moving files to ease oshima's concurrent Shelf CL.

Consolidate WmShelf[Aura|Mus] functionality on WmShelf.
WmShelfMus ctor inits Shelf, ShelfView, ShelfWidget, etc.
Use a ShelfDelegateStub for now; add TODO for real impl.
WmShelfAura still uses root event handlers; shelf dimmer.

Nix ShelfIconObserver interface; use WmShelfObserver.
Nix redundant mash RootWindowController::CreateStatusArea.
Change ShelfWidget's WmShelfAura* member to WmShelf*.

Call WmShell::ShutDown before destruction in WindowManager.
Teardown PointerWatcherEventRouter after window destruction.

BUG= 557406 , 612631 , 615155 , 621112 
TEST=Automated; no cros changes; chrome --mash has a shelf.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2247503002
Cr-Commit-Position: refs/heads/master@{#412630}

[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/ash.gyp
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/DEPS
[delete] https://crrev.com/8b8b2cd33a7685b4b4d51e3d778073be4b526897/ash/common/shelf/shelf_icon_observer.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/shelf_view.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/wm_shell.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/wm_shell.h
[add] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/DEPS
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/root_window_controller.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/root_window_controller.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/window_manager.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/root_window_controller.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_widget.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ui/views/mus/pointer_watcher_event_router.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ui/views/mus/pointer_watcher_event_router.h
Project Member

Comment 58 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df64c66b915f64f2356cdecd0450f3bf75f144b9

commit df64c66b915f64f2356cdecd0450f3bf75f144b9
Author: msw <msw@chromium.org>
Date: Tue Aug 23 18:56:37 2016

mash: Move more shelf files to ash/common/shelf.

tools/git/move_source_file.py ash/shelf/shelf.* ash/common/shelf/
tools/git/move_source_file.py ash/shelf/shelf_layout_manager.* ash/common/shelf/
tools/git/move_source_file.py ash/shelf/shelf_layout_manager_observer.h ash/common/shelf/
tools/git/move_source_file.py ash/shelf/shelf_widget.* ash/common/shelf/

tools/git/move_source_file.py ash/common/shelf/status_area_layout_manager.h ash/common/system/

Update Shelf::ForWindow impl; remove constness of param.
Remove DEPS exceptions for moved files.

BUG= 615155 
TEST=Automated; no functional changes.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2268823002
Cr-Commit-Position: refs/heads/master@{#413798}

[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/ash.gyp
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/aura/wm_shelf_aura.cc
[delete] https://crrev.com/cb38b2fb3d28b76924bf90ce98ce543b43f05e45/ash/common/shelf/DEPS
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf.cc
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf.h
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_layout_manager.cc
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_layout_manager.h
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_layout_manager_observer.h
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_view.cc
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_widget.cc
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/shelf_widget.h
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/shelf/wm_shelf.h
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/system/status_area_layout_manager.cc
[rename] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/common/system/status_area_layout_manager.h
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/dip_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/display/screen_ash.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/focus_cycler_unittest.cc
[delete] https://crrev.com/cb38b2fb3d28b76924bf90ce98ce543b43f05e45/ash/mus/bridge/DEPS
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/root_window_controller.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/screen_util.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shelf/shelf_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shell.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shell/window_watcher.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/shell_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/sysui/shelf_delegate_mus.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/test/shelf_test_api.h
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/window_animations.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/chromeos/first_run/steps/tray_step.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/ash/shelf_browsertest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc
[modify] https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
Project Member

Comment 59 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/828394031639b3305df4fbae8a41d6c730003262

commit 828394031639b3305df4fbae8a41d6c730003262
Author: msw <msw@chromium.org>
Date: Tue Aug 30 18:57:29 2016

mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG= 557406 , 614182 , 615155 , 616857 
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2259153002
Cr-Commit-Position: refs/heads/master@{#415378}

[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/BUILD.gn
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/DEPS
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/root_window_controller.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/root_window_controller.h
[add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shelf_delegate_mus.cc
[add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shelf_delegate_mus.h
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager.cc
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager.h
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager_delegate.h
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/window_manager_application.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/window_manager_application.h
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/BUILD.gn
[rename] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf.mojom
[add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf.typemap
[add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf_enum_traits.h
[add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/typemaps.gni
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/BUILD.gn
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/sysui/shelf_delegate_mus.cc
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/sysui/shelf_delegate_mus.h
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/sysui_application.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/sysui_application.h
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.h
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/mash/shelf/public/interfaces/BUILD.gn
[delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/mash/shelf/public/interfaces/shelf_constants.mojom
[modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Comment 60 by jamescook@chromium.org, Aug 31 2016

Status: Fixed (was: Started)
I declare victory. We can address fixing individual features (auto-hide in mus) in separate bugs.

Comment 61 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment