add antivirus information to the system profile |
|||||||||||||||||||||||||
Issue descriptionIt would be good to have information on which AntiVirus is installed. This can be obtained from WMI or via COM interface In order to allow slicing data (e.g. stability data, or UMA histograms) by this AntiVirus data, this should probably be in the system profile.
,
May 26 2016
,
May 26 2016
,
May 26 2016
Have you discussed this with privacy team yet? If not, please start a thread with chrome-privacy-core@.
,
May 26 2016
Design/discussion doc https://docs.google.com/document/d/1Rk6lBD7Geb4XYZUjgXsNb0JB2XLKjrhoBAxSF6GHlsY/edit
,
May 27 2016
,
Jun 8 2016
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c768983fac1178f0219e1f7aab38200c7d87d8b4 commit c768983fac1178f0219e1f7aab38200c7d87d8b4 Author: wfh <wfh@chromium.org> Date: Wed Jun 08 16:40:33 2016 Add AntiVirus information to the system profile. Collection happens after Google Update data has been collected and before drive metrics data, on the FILE thread. BUG=615154 TEST=unit_tests TEST=manual, check system profile contains AV information via logging. Review-Url: https://codereview.chromium.org/2009773007 Cr-Commit-Position: refs/heads/master@{#398597} [add] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/browser/metrics/antivirus_metrics_provider_win.cc [add] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/browser/metrics/antivirus_metrics_provider_win.h [add] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/browser/metrics/chrome_metrics_service_client.h [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/chrome_browser.gypi [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/components/metrics/proto/system_profile.proto [modify] https://crrev.com/c768983fac1178f0219e1f7aab38200c7d87d8b4/tools/metrics/histograms/histograms.xml
,
Jun 10 2016
,
Jun 10 2016
The API being used here only works on Win8 and above, so the WMI method will have to be added also to get full Win7 coverage.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e8be206b2e8a96af660720bef1450f8a06af167 commit 1e8be206b2e8a96af660720bef1450f8a06af167 Author: wfh <wfh@chromium.org> Date: Fri Jun 17 20:41:05 2016 Add support for obtaining AV products on Win7. Previously WSC API was used which is only available on Windows 8. This CL adds support via WMI, which is available from Vista onwards. BUG=615154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2064313004 Cr-Commit-Position: refs/heads/master@{#400496} [modify] https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167/tools/metrics/histograms/histograms.xml
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d5dcb97d95c6afff63c4cb9b5d9794901a4816f commit 7d5dcb97d95c6afff63c4cb9b5d9794901a4816f Author: wfh <wfh@chromium.org> Date: Fri Jun 17 23:13:39 2016 Revert "Add support for obtaining AV products on Win7." This reverts commit 1e8be206b2e8a96af660720bef1450f8a06af167. BUG=621235,615154 Skipping CQ checks because original CL landed less than 1 day(s) ago. TBR=jschuh@chromium.org,rkaplow@chromium.org,grt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2078093002 Cr-Commit-Position: refs/heads/master@{#400535} [modify] https://crrev.com/7d5dcb97d95c6afff63c4cb9b5d9794901a4816f/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/7d5dcb97d95c6afff63c4cb9b5d9794901a4816f/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/7d5dcb97d95c6afff63c4cb9b5d9794901a4816f/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/7d5dcb97d95c6afff63c4cb9b5d9794901a4816f/tools/metrics/histograms/histograms.xml
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6813e4fdd732d11c532c02fd07e16f6c76df78ab commit 6813e4fdd732d11c532c02fd07e16f6c76df78ab Author: wfh <wfh@chromium.org> Date: Fri Jul 01 22:03:45 2016 Add support for obtaining AV products on Win7. Previously WSC API was used which is only available on Windows 8. This CL adds support via WMI, which is available from Vista onwards. BUG=615154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167 Review-Url: https://codereview.chromium.org/2064313004 Cr-Original-Commit-Position: refs/heads/master@{#400496} Cr-Commit-Position: refs/heads/master@{#403544} [modify] https://crrev.com/6813e4fdd732d11c532c02fd07e16f6c76df78ab/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/6813e4fdd732d11c532c02fd07e16f6c76df78ab/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/6813e4fdd732d11c532c02fd07e16f6c76df78ab/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/6813e4fdd732d11c532c02fd07e16f6c76df78ab/tools/metrics/histograms/histograms.xml
,
Jul 7 2016
1e8be206b2e8a96af660720bef1450f8a06af167 has been on Canary for a while now and gives valid data from Win7 - see https://uma.googleplex.com/p/chrome/timeline_v2?sid=07514895da9f68a31d31d13a574b2c54. I'd like to merge this CL into M53.
,
Jul 7 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b75c31bb3974d9749085aad6f2420cf7e9d731af commit b75c31bb3974d9749085aad6f2420cf7e9d731af Author: Will Harris <wfh@chromium.org> Date: Thu Jul 07 17:00:05 2016 Merge M53: Add support for obtaining AV products on Win7. Previously WSC API was used which is only available on Windows 8. This CL adds support via WMI, which is available from Vista onwards. BUG=615154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167 Review-Url: https://codereview.chromium.org/2064313004 Cr-Original-Commit-Position: refs/heads/master@{#400496} Cr-Commit-Position: refs/heads/master@{#403544} (cherry picked from commit 6813e4fdd732d11c532c02fd07e16f6c76df78ab) Review URL: https://codereview.chromium.org/2132693002 . Cr-Commit-Position: refs/branch-heads/2785@{#43} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/b75c31bb3974d9749085aad6f2420cf7e9d731af/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/b75c31bb3974d9749085aad6f2420cf7e9d731af/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/b75c31bb3974d9749085aad6f2420cf7e9d731af/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/b75c31bb3974d9749085aad6f2420cf7e9d731af/tools/metrics/histograms/histograms.xml
,
Jul 11 2016
I'd quite like to get this into M52 as it's important to get stability data on Stable channel.
,
Jul 11 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 11 2016
wfh@, can you please merge it as soon as you can in to the M52 branch as we have the early stable release planned on July 20th and we have a beta release scheduled this Wednesday [July 13]
,
Jul 11 2016
CL is https://codereview.chromium.org/2136423003/ and I'm testing it with a local build before committing it to M52 (2743) branch.
,
Jul 12 2016
Compiles and tests pass fine on branch 2743 so committing now.
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04f78ed689838121983aa7019f1744d188dd1ced commit 04f78ed689838121983aa7019f1744d188dd1ced Author: Will Harris <wfh@chromium.org> Date: Tue Jul 12 01:21:25 2016 Merge M52: Add AntiVirus information to the system profile. Collection happens after Google Update data has been collected and before drive metrics data, on the FILE thread. BUG=615154 TEST=unit_tests TEST=manual, check system profile contains AV information via logging. Review-Url: https://codereview.chromium.org/2009773007 Cr-Commit-Position: refs/heads/master@{#398597} (cherry picked from commit c768983fac1178f0219e1f7aab38200c7d87d8b4) Merge M52: Add support for obtaining AV products on Win7. Previously WSC API was used which is only available on Windows 8. This CL adds support via WMI, which is available from Vista onwards. BUG=615154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167 Review-Url: https://codereview.chromium.org/2064313004 Cr-Original-Commit-Position: refs/heads/master@{#400496} Cr-Commit-Position: refs/heads/master@{#403544} (cherry picked from commit 6813e4fdd732d11c532c02fd07e16f6c76df78ab) Review URL: https://codereview.chromium.org/2132693002 . Cr-Commit-Position: refs/branch-heads/2785@{#43} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} (cherry picked from commit b75c31bb3974d9749085aad6f2420cf7e9d731af) Review URL: https://codereview.chromium.org/2136423003 . Cr-Commit-Position: refs/branch-heads/2743@{#613} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [add] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/browser/metrics/antivirus_metrics_provider_win.cc [add] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/browser/metrics/antivirus_metrics_provider_win.h [add] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/browser/metrics/chrome_metrics_service_client.h [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/chrome_browser.gypi [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/components/metrics/proto/system_profile.proto [modify] https://crrev.com/04f78ed689838121983aa7019f1744d188dd1ced/tools/metrics/histograms/histograms.xml
,
Jul 12 2016
,
Jul 19 2016
Could anyone please let us know is this issue has any manual test steps to verify it from chrome TE end?
,
Jul 19 2016
You should see the histogram UMA.AntiVirusMetricsProvider.Result with a value of 0.
,
Jul 19 2016
Verified the fix on latest Chrome Dev i.e., 53.0.2785.21 : Steps Followed : 1. Install and launch Chrome 2. Make sure UMA metrics are enabled from Chrome://settings 3. navigate to "chrome://local-state/" and make sure "saved_system_profile" is present (If you don't see this try to launch Chrome using "chrome.exe --user-data-dir=c:\some_new_dir" wait for 1min) 4. navigate to "Chrome://histograms" Expected/Observed behavior : A histogram should be present Histogram: UMA.AntiVirusMetricsProvider.Result recorded 1 samples, average = 0.0 (flags = 0x1) 0 ------------------------------------------------------------------------O (1 = 100.0%) 1 ...
,
Jul 28 2016
Verified the issue on Latest Beta# 53.0.2785.34 on Windows and is as intended. Histograms are displayed under chrome://histograms/UMA and chrome://histograms successfully. Hence adding TE-Verified Labels. Attaching a screenshot for reference. Thank You.
,
Dec 12 2016
Some antivirus/antimalware products do not register themselves in the Security Center. Based on the metrics from M54, I'll add "ad hoc" product detection to the existing code to show them as installed. This will start with Trusteer Rapport which intentionally does not register in Security Center as it is intended to operate at the same time as other AV products.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b6a82030b3d331ce561fc781b3861af99c89b24 commit 4b6a82030b3d331ce561fc781b3861af99c89b24 Author: wfh <wfh@chromium.org> Date: Wed Dec 14 21:53:16 2016 Add support to detect unregistered AV products in system profile. Some products do not register with WMI or Security Center. Add a "best effort" attempt to enumerate these and add them to the system profile, starting with IBM/Trusteer Rapport Endpoint Security. BUG=615154 TEST=manual - see https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjwlY/edit Review-Url: https://codereview.chromium.org/2578453002 Cr-Commit-Position: refs/heads/master@{#438641} [modify] https://crrev.com/4b6a82030b3d331ce561fc781b3861af99c89b24/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/4b6a82030b3d331ce561fc781b3861af99c89b24/chrome/browser/metrics/antivirus_metrics_provider_win.h
,
Dec 15 2016
Data is arriving for latest commit in 57.0.2952.0 and looks valid, so I'd like to merge 4b6a82030b3d331ce561fc781b3861af99c89b24 to M56 to get data sooner from a larger population.
,
Dec 15 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d385515a547f87d04094c2be6ae21f9931e6660e commit d385515a547f87d04094c2be6ae21f9931e6660e Author: Will Harris <wfh@chromium.org> Date: Thu Dec 15 22:32:55 2016 Merge M56: Add support to detect unregistered AV products in system profile. Some products do not register with WMI or Security Center. Add a "best effort" attempt to enumerate these and add them to the system profile, starting with IBM/Trusteer Rapport Endpoint Security. BUG=615154 TEST=manual - see https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjwlY/edit Review-Url: https://codereview.chromium.org/2578453002 Cr-Commit-Position: refs/heads/master@{#438641} (cherry picked from commit 4b6a82030b3d331ce561fc781b3861af99c89b24) Review URL: https://codereview.chromium.org/2576313003 . Cr-Commit-Position: refs/branch-heads/2924@{#518} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d385515a547f87d04094c2be6ae21f9931e6660e/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/d385515a547f87d04094c2be6ae21f9931e6660e/chrome/browser/metrics/antivirus_metrics_provider_win.h
,
Jan 3 2017
Verified the issue on windows 10 using chrome dev version #57.0.2970.0 as per comment #27 Observed that histograms are displayed under chrome://histograms/UMA and chrome://histograms successfully. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!!
,
Jan 4 2017
Verified the issue on windows 10 using chrome dev version #56.0.2924.51 as per comment #27 Observed that histograms are displayed under chrome://histograms/UMA and chrome://histograms successfully. Hence, the fix is working as expected. Attaching screenshot for reference. Hence, adding the verified labels. Thanks...!!
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da07d58a5d041395d3d6317ab3aef31c0087285e commit da07d58a5d041395d3d6317ab3aef31c0087285e Author: wfh <wfh@chromium.org> Date: Fri Jan 13 17:27:28 2017 Trim version and extraneus parts from AntiVirus product names. Some AV products include their version in the product name in WMI which makes maintaining the list of hashes of product names onerous. Therefore, trim anything that looks like a version, along with trailing spaces. BUG=615154 TEST=unit_tests --gtest_filter=AntiVirusMetricsProvider* Review-Url: https://codereview.chromium.org/2631583002 Cr-Commit-Position: refs/heads/master@{#443594} [modify] https://crrev.com/da07d58a5d041395d3d6317ab3aef31c0087285e/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/da07d58a5d041395d3d6317ab3aef31c0087285e/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/da07d58a5d041395d3d6317ab3aef31c0087285e/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ce0d75da469537fd542b02ed0cf36bd9d95ecb7 commit 1ce0d75da469537fd542b02ed0cf36bd9d95ecb7 Author: wfh <wfh@chromium.org> Date: Tue Jan 17 23:20:54 2017 Correctly call trim function from antivirus metrics. BUG=615154 Review-Url: https://codereview.chromium.org/2635333002 Cr-Commit-Position: refs/heads/master@{#444182} [modify] https://crrev.com/1ce0d75da469537fd542b02ed0cf36bd9d95ecb7/chrome/browser/metrics/antivirus_metrics_provider_win.cc
,
Jan 18 2017
Verified this is working on 57.0.2985.0 using query - https://plx.corp.google.com/script/#a=qo%7Ci=google%253A%253Ascript_72._385096_33b2_4cd0_9b2b_ab61216aaff0 I'd like to merge this code into M56 - so requesting merge for da07d58 and 1ce0d75. Thanks!
,
Jan 18 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
LGTM for merge in M56 for da07d58 and then 1ce0d75
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cb5cebfa54152b226f9ec83589d79af4815c7da commit 1cb5cebfa54152b226f9ec83589d79af4815c7da Author: Will Harris <wfh@chromium.org> Date: Wed Jan 18 19:57:56 2017 Merge M56:Trim AV names. Correctly call trim function from antivirus metrics. BUG=615154 Review-Url: https://codereview.chromium.org/2635333002 Cr-Commit-Position: refs/heads/master@{#444182} (cherry picked from commit 1ce0d75da469537fd542b02ed0cf36bd9d95ecb7) Trim version and extraneus parts from AntiVirus product names. Some AV products include their version in the product name in WMI which makes maintaining the list of hashes of product names onerous. Therefore, trim anything that looks like a version, along with trailing spaces. BUG=615154 TEST=unit_tests --gtest_filter=AntiVirusMetricsProvider* Review-Url: https://codereview.chromium.org/2631583002 Cr-Commit-Position: refs/heads/master@{#443594} (cherry picked from commit da07d58a5d041395d3d6317ab3aef31c0087285e) Review-Url: https://codereview.chromium.org/2645473003 . Cr-Commit-Position: refs/branch-heads/2924@{#794} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/1cb5cebfa54152b226f9ec83589d79af4815c7da/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/1cb5cebfa54152b226f9ec83589d79af4815c7da/chrome/browser/metrics/antivirus_metrics_provider_win.h [modify] https://crrev.com/1cb5cebfa54152b226f9ec83589d79af4815c7da/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by wfh@chromium.org
, May 26 2016Components: Security