New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615134 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

toosl/perf/run_benchmark cannot detect page_cycler.typical_25

Project Member Reported by nedngu...@google.com, May 26 2016

Issue description

./tools/perf/run_benchmark --browser=system page_cycler.typical_25

No benchmark named "page_cycler.typical_25".

Do you mean any of those benchmarks below?
Available benchmarks are:
  page_cycler.basic_oopif                 A benchmark measuring performance of the out-of-process iframes page
  page_cycler.intl_ar_fa_he              Page load time for a variety of pages in Arabic, Farsi and Hebrew.
  page_cycler.intl_es_fr_pt-BR           Page load time for a pages in Spanish, French and Brazilian Portuguese.
  page_cycler.intl_hi_ru                 Page load time benchmark for a variety of pages in Hindi and Russian.
  page_cycler.intl_ja_zh                 Page load time benchmark for a variety of pages in Japanese and Chinese.
  page_cycler.intl_ko_th_vi              Page load time for a variety of pages in Korean, Thai and Vietnamese.
  page_cycler.top_10_mobile              Page load time benchmark for the top 10 mobile web pages.
  page_cycler.tough_layout_cases         Page loading for the slowest layouts observed in the Alexa top 1 million.
  page_cycler_site_isolation.basic_oopif  A benchmark measuring performance of out-of-process iframes. 
  page_cycler_v2.typical_25              Page load time benchmark for a 25 typical web pages.
  power.top_10                           Top 10 quiescent power test.
  power.top_25                           Top 25 quiescent power test.
  power.typical_10_mobile                Android typical 10 mobile power test.
  power.typical_10_mobile_reload         Android typical 10 mobile power reload test.
  tab_switching.typical_25               This test records the MPArch.RWH_TabSwitchPaintDuration histogram.
Pass --browser to list benchmarks for another browser.

This happens while page_cycler.typical_25 still exist & is not disabled on any platform
 
Cc: llozano@chromium.org kouhei@chromium.org
Due to some bug in telemetry's discover module, it failed to detect page_cycler.typical_25 benchmark because that benchmark's class name is the same as page_cycler_v2.typical_25 

https://codereview.chromium.org/2012223003 is the bandaid fix that rename the class name of page_cycler_v2.typical_25 from PageCyclerTypical25 to PageCyclerV2Typical25
Cc: dtu@chromium.org aiolos@chromium.org
Found the bug:
Telemetry discover all benchmarks using class_name, hence it ignore benchmarks with duplicate class name:
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/benchmark_runner.py#L249

*I think it's time for us to kill discover by class name.
Owner: nedngu...@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77dbb30efe645b494e8a544a3fff3f370e31bfa

commit a77dbb30efe645b494e8a544a3fff3f370e31bfa
Author: nednguyen <nednguyen@google.com>
Date: Thu May 26 20:22:43 2016

[tools/perf] Rename page_cycler_v2.PageCyclerTypical25 to page_cycler_v2.PageCyclerV2Typical25

BUG= 615134 

Review-Url: https://codereview.chromium.org/2012223003
Cr-Commit-Position: refs/heads/master@{#396269}

[modify] https://crrev.com/a77dbb30efe645b494e8a544a3fff3f370e31bfa/tools/perf/benchmarks/page_cycler_v2.py

Project Member

Comment 6 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Status: Verified (was: Untriaged)
This is running successfully again in the lab. Marking as Verified.

Sign in to add a comment