There currently is no OWNERS file for chrome/tools/mac_helpers, which means that if someone makes changes in that directory, they have to ask chrome/OWNERS for a review (and I imagine it would list members of the Chrome Mac team).
Maybe chrome/tools/mac_helpers/OWNERS should just contain: file://chrome/browser/mac/OWNERS ??
Are we using anything from this directory in the Mac gn build?
Just infoplist_strings_util.mm. That can probably move to //chrome/tools/build/mac instead. I'll do that after we remove GYP.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a22fdb230ae32c544d870cb55fbf3643a82adb9 commit 4a22fdb230ae32c544d870cb55fbf3643a82adb9 Author: rsesek <rsesek@chromium.org> Date: Fri Mar 31 01:34:48 2017 Delete several unused GYP scripts from build/mac and chrome/tools/build/mac. This also adds rsesek@ as an OWNER of chrome/tools/build/mac. BUG= 615107 R=mark@chromium.org TBR=thakis@chromium.org Review-Url: https://codereview.chromium.org/2793433002 Cr-Commit-Position: refs/heads/master@{#460981} [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/build/mac/copy_asan_runtime_dylib.sh [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/build/mac/copy_framework_unversioned.sh [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/build/mac/strip_from_xcode [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/build/mac/strip_save_dsym [modify] https://crrev.com/4a22fdb230ae32c544d870cb55fbf3643a82adb9/chrome/installer/mac/sign_versioned_dir.sh.in [modify] https://crrev.com/4a22fdb230ae32c544d870cb55fbf3643a82adb9/chrome/tools/build/mac/OWNERS [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/chrome/tools/build/mac/clean_up_old_versions [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/chrome/tools/build/mac/dump_product_syms [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/chrome/tools/build/mac/make_locale_dirs.sh [delete] https://crrev.com/899415b21db5d6befa5fdf7f38b256e346dcb465/chrome/tools/mac_helpers/lipo_thin_x86_64.sh
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eef763fec7479bb937647bfd7e1659d916f38a6 commit 0eef763fec7479bb937647bfd7e1659d916f38a6 Author: rsesek <rsesek@chromium.org> Date: Fri Mar 31 01:37:22 2017 Move //chrome/tools/mac_helpers:infoplist_strings_util to //chrome/tools/build/mac. NOPRESUBMIT=true BUG= 615107 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2783413002 Cr-Commit-Position: refs/heads/master@{#460982} [modify] https://crrev.com/0eef763fec7479bb937647bfd7e1659d916f38a6/chrome/BUILD.gn [rename] https://crrev.com/0eef763fec7479bb937647bfd7e1659d916f38a6/chrome/tools/build/mac/BUILD.gn [rename] https://crrev.com/0eef763fec7479bb937647bfd7e1659d916f38a6/chrome/tools/build/mac/DEPS [rename] https://crrev.com/0eef763fec7479bb937647bfd7e1659d916f38a6/chrome/tools/build/mac/infoplist_strings_util.mm
Comment 1 by shrike@chromium.org
, May 26 2016