Issue 615104 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ yolandyan@chromium.org not available
Closed:	Jun 2016
Cc:	█ mkwst@chromium.org █ mikec...@chromium.org w...@chromium.org █ sgu...@chromium.org jbudorick@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Separate BaseInstrumentationTestRunner from BaseChromiumInstrumentationTestRunner

Project Member Reported by yolandyan@chromium.org, May 26 2016

Issue description

Current BaseInstrumentationTestRunner utilize CommandLineFlags.getRegistrationHook() would be default regard/cast the test target apk application as BaseChromiumApplication. However, there are WebView related apks (system webview shell) that doesn't use BaseChromiumApplication as their <application>.

This CL is to separate none BaseChromiumApplication related component from BaseInstrumentationTestRunner, so that the webview related apks can still utilize features like customized test annotations
https://codereview.chromium.org/2013113002

Comment 1 by yolandyan@chromium.org, May 26 2016

Status: Started (was: Untriaged)

After the CL, apks that uses BaseChromiumApplication should use BaseChromiumInstrumentationTestRunner instead of BaseInstrumentationTestRunner

Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60c6ae2a354c9f99ebd787e577cf7972da3e985c

commit 60c6ae2a354c9f99ebd787e577cf7972da3e985c
Author: yolandyan <yolandyan@google.com>
Date: Tue May 31 20:04:50 2016

Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG= 615104 

Review-Url: https://codereview.chromium.org/2013113002
Cr-Commit-Position: refs/heads/master@{#396906}

[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/android_webview/test/shell/src/org/chromium/android_webview/test/AwInstrumentationTestRunner.java
[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/base/BUILD.gn
[add] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java
[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/blimp/client/app/android/javatests/AndroidManifest.xml.jinja2
[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c/content/shell/android/javatests/AndroidManifest.xml

Comment 3 by yolandyan@chromium.org, Jun 24 2016

Status: Fixed (was: Started)

►

Issue 615104 link

Issue metadata

Separate BaseInstrumentationTestRunner from BaseChromiumInstrumentationTestRunner

Issue description

Comment 1 by yolandyan@chromium.org, May 26 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 31 2016

Comment 2 Deleted

Comment 3 by yolandyan@chromium.org, Jun 24 2016

Comment 3 Deleted

Sign in to add a comment