New issue
Advanced search Search tips

Issue 615062 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

In password separated signin flow, SAML sign in keeps the modal open

Project Member Reported by anthonyvd@chromium.org, May 26 2016

Issue description

The modal should close when the flow breaks out to a new tab for the SAML provider's page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4650fea14f2e295f3176003ba3fff58926894e35

commit 4650fea14f2e295f3176003ba3fff58926894e35
Author: anthonyvd <anthonyvd@chromium.org>
Date: Wed Jun 01 22:49:54 2016

Properly handle dialogClose message in password separated sign in flow.

This fixes an issue where the flow would stay open when breaking to a
full tab during SAML sign in flows.

BUG= 615062 
TEST=
1. Enable #enable-password-separated-signin-flow in chrome://flags
2. Signin flow window properly closes after all sign ins
3. Signin flow window properly closes after entering SAML email and
   opening SAML provider's page in full tab.

Review-Url: https://codereview.chromium.org/2023763013
Cr-Commit-Position: refs/heads/master@{#397276}

[modify] https://crrev.com/4650fea14f2e295f3176003ba3fff58926894e35/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/4650fea14f2e295f3176003ba3fff58926894e35/chrome/browser/ui/webui/signin/inline_login_handler.h
[modify] https://crrev.com/4650fea14f2e295f3176003ba3fff58926894e35/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment