Issue metadata
Sign in to add a comment
|
1.5%-12.5% improvement in webrtc_perf_tests at 12846:12846 |
||||||||||||||||||||||
Issue descriptionkwiberg, appears your https://codereview.webrtc.org/2002523002 is tied to some improvements. Check if this is what you expected. It does sound a bit far-fetched, no? https://codereview.webrtc.org/1987663002 by nisse@ is also pretty close.
,
May 26 2016
Nisse, one of your patches is also pretty close to this one.
,
May 26 2016
It's not totally unreasonable that https://codereview.webrtc.org/2002523002 would improve performance. As I note in the commit message, "Also, the new [WebRtcSpl_AddSatW32 and WebRtcSpl_SubSatW32] implementations, unlike the old ones, result in branch-free code (tested with clang 3.9 with -O2)." That said, unless the tests are spending a large fraction of their time doing fixed-point audio math, I would certainly not expect that CL to have such a large impact.
,
May 26 2016
My cl above should affect android only, so that seems unrelated.
,
May 30 2016
Hmm. How can I reproduce this locally? I'd like to test with and without my CL.
,
Jul 6 2016
,
Sep 7 2016
Closing this, since it seems unlikely that investigating a somewhat unexpected minor performance increase is more important than fixing other bugs. Anyone who disagrees, feel free to re-open... |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by phoglund@chromium.org
, May 26 2016