Regression: Highlight is stuck after long tap/touch on downloaded file in download bar.
Reported by
jshan...@etouch.net,
May 26 2016
|
||||||||
Issue descriptionChrome Version: 52.0.2743.10 (Official Build) 18f7321a2c4403368e9e5e53f5396ede2d60b2f7-refs/branch-heads/2743@{#70} (32/64-bit) OS: Windows 10(Touch device) Pre-condition: Enable 'Material Design in the browser's top chrome' from chrome://flags Steps: 1. Launch Chrome and download any page. 2. Long tap/touch on downloaded page seen in download bar. 3. Now click anywhere on page, reload the page and observe. Actual: Highlight is stuck after long tap/touch on downloaded file in download bar. Expected: Highlight should not stuck after long tap/touch on downloaded file in download bar. This is a regression issue broken in M-51,below is bisect info Good build: 51.0.2700.0 Bad build: 51.0.2701.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/1b66d9cd30ed716b1defc9f4018b0001e0699f1d..7d0b8e68976cdd63274f72e507559d413c7debb8?pretty=fuller&n=100 Suspecting: r385052 ? Please help to re-assign if your change is not the cause for this issue. Note: This is touch device specific issue, same works fine on mouse click.
,
Jun 28 2016
Yes, it seems that this bug is fixed as a result of the fix to bug 595315
,
Jun 28 2016
thanks. p3 then
,
Jun 30 2016
I suspect the InkDropHostView::InkDropGestureHandler::OnGestureEvent() function is not getting some expected |event|s because the menu is capturing them. Not sure at this point about any possible solutions though.
,
Jun 30 2016
,
Mar 8 2017
,
Mar 8 2017
,
Apr 18 2017
,
May 29 2017
,
May 29 2017
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc1f110c5a1fc9fab3e79a83206000bf0aa61e0 commit 5dc1f110c5a1fc9fab3e79a83206000bf0aa61e0 Author: bruthig <bruthig@chromium.org> Date: Tue May 30 17:52:08 2017 [ui] Hide the ink highlight on the download bar when showing a context menu. BUG= 615013 TEST=manual Review-Url: https://codereview.chromium.org/2913643002 Cr-Commit-Position: refs/heads/master@{#475590} [modify] https://crrev.com/5dc1f110c5a1fc9fab3e79a83206000bf0aa61e0/chrome/browser/ui/views/download/download_item_view.cc
,
May 30 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by est...@chromium.org
, Jun 27 2016Labels: -Pri-1 -Type-Bug-Regression -M-51 M-54 OS-Linux Pri-2 Type-Bug