Issue metadata
Sign in to add a comment
|
Regression: App image is not seen properly on 'Confirm Removal' overlay in chrome://appps.
Reported by
rk...@etouch.net,
May 26 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: Chrome Version: 52.0.2743.10 Revision 18f7321a2c4403368e9e5e53f5396ede2d60b2f7-refs/branch-heads/2743@{#70}(32/64 bit) OS: Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome and go to chrome://apps page. (2) Drag the Webstore link at bottom into chrome://apps page (shortcut is created). (3) Right click on Webstore shortcut, select 'App info' option then click on 'Remove' (4) observe the app image on 'Confirm Removal' overlay. App image is not seen properly i.e. upper boarder is not seen on app info overlay. App image should seen properly. This is a regression issue, broken in 'M-51' , below is bisect info: Good Build: 51.0.2694.0 Bad Build: 51.0.2695.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/21832bf93e466609a4a497e0d67e8f865ab2e13f..bb82fe13a37b08e56ac801360d4cbf5eeba7a9dd?pretty=fuller&n=100 Suspecting: r384118 ? or r384114 ? Note: Issue is not seen on Mac(10.10.5, 10.11.4) OS.
,
May 26 2016
not my change.
,
May 26 2016
This must be a chrome bug similar to crbug.com/605884 . I'll look into it.
,
May 26 2016
,
May 31 2016
Just to update the Issue is reproduced on 53.0.2753.0 .
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b801ad2f00aff615076a2a1c22d76b68e61ae687 commit b801ad2f00aff615076a2a1c22d76b68e61ae687 Author: oshima <oshima@chromium.org> Date: Wed Jun 01 03:27:45 2016 Just use the image skia from resouce bundle for default app icon. Another issue similar to 605884. BUG= 614992 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2012273002 Cr-Commit-Position: refs/heads/master@{#397040} [modify] https://crrev.com/b801ad2f00aff615076a2a1c22d76b68e61ae687/chrome/browser/extensions/extension_uninstall_dialog.cc
,
Jun 3 2016
Just to update: Above issue seems to be fixed in latest canary version 53.0.2757.0 Thank you.
,
Jun 3 2016
thanks for the update. Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 53.0.2757.0.able to see the complete image on removal overlay popup. Please find the attached screen shot for the same. Adding TE-Verified label. Thanks,
,
Jun 3 2016
Thanks for the fix. oshima@ could you please request a merge to M52.
,
Jun 3 2016
,
Jun 3 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f94447b764c82dbf7aeb27c0a087ffd6c9b1ae7d commit f94447b764c82dbf7aeb27c0a087ffd6c9b1ae7d Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Jun 03 22:35:26 2016 Just use the image skia from resouce bundle for default app icon. Another issue similar to 605884. BUG= 614992 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2012273002 Cr-Commit-Position: refs/heads/master@{#397040} (cherry picked from commit b801ad2f00aff615076a2a1c22d76b68e61ae687) Review URL: https://codereview.chromium.org/2034293002 . Cr-Commit-Position: refs/branch-heads/2743@{#218} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/f94447b764c82dbf7aeb27c0a087ffd6c9b1ae7d/chrome/browser/extensions/extension_uninstall_dialog.cc
,
Jun 3 2016
Thanks for the merge.If there is no pending work please tag as fixed.
,
Jun 6 2016
,
Jun 8 2016
Rechecked the issue on Windows 7, Windows 10, ubuntu 14.04. Merge is working as intended. App Image is displayed properly on Confirm Removal Overlay. Attached screenshot for the same. Thanks.! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 26 2016