ServiceWorkerMicrobenchmark has incorrect order of params to new Response() |
||
Issue description
The first arg to Response ctor is the body. But our SW microbenchmark is trying to pass headers to it:
var response = new Response({
statusCode: 200,
statusText: 'OK',
method: 'GET'
});
It should really be something like:
var response = new Response('hello world');
https://github.com/horo-t/Service-Worker-Performance/blob/0cc35c2398526665399ca99fe53147ff81101408/request-latency-worker.js
Tentatively assigning to shimazu.
,
Jun 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/622df80e954a2ead9cdd6f242ae7bf301dd81bda commit 622df80e954a2ead9cdd6f242ae7bf301dd81bda Author: shimazu <shimazu@chromium.org> Date: Sat Jun 04 02:18:18 2016 ServiceWorker: Fix the argument of ctor of Response The first argument to Response constructor should be the body while currently passing the header. This patch fixed it and updated the pageset. BUG= 614985 Review-Url: https://codereview.chromium.org/2032893003 Cr-Commit-Position: refs/heads/master@{#397891} [modify] https://crrev.com/622df80e954a2ead9cdd6f242ae7bf301dd81bda/tools/perf/page_sets/data/service_worker_micro_benchmark.json [add] https://crrev.com/622df80e954a2ead9cdd6f242ae7bf301dd81bda/tools/perf/page_sets/data/service_worker_micro_benchmark_004.wpr.sha1 [modify] https://crrev.com/622df80e954a2ead9cdd6f242ae7bf301dd81bda/tools/perf/page_sets/service_worker_micro_benchmark.py
,
Jun 6 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by shimazu@chromium.org
, May 31 2016