New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614983 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 487937



Sign in to add a comment

Create a finch experiment for rendering pipeline throttling

Project Member Reported by skyos...@chromium.org, May 26 2016

Issue description

Create a finch experiment for evaluating the impact of rendering pipeline throttling.
 
Owner: skyos...@chromium.org
Status: Started (was: Untriaged)
Patch to add feature flag: https://codereview.chromium.org/2014183002/
Cc: kenjibaheux@chromium.org
Finch experiment: cl/123313061
(The above CL also assigns an id to the experiment so its impact can be monitored on the server side too.)
Labels: Merge-Request-52 M-52
Status: Fixed (was: Started)
Requesting to merge the feature flag to M52.
Cc: ligim...@chromium.org
1. Is there a launch bug associated to this feature?
2. Approved by Launch Review team?
3. Is it safe to merge before baking in canary?

Comment 7 by tin...@google.com, May 28 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Yes, there is a launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=516640

FWIW this feature flag is needed in M52 for turning the feature *off* via a Finch experiment. The feature itself is already there in M52.
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30eaebb30490917efb80e7ebd4a82be301efb98b

commit 30eaebb30490917efb80e7ebd4a82be301efb98b
Author: Sami Kyostila <skyostil@chromium.org>
Date: Tue May 31 09:41:22 2016

Add a feature flag for enabling rendering pipeline throttling

Add a feature flag for rendering pipeline throttling so we can evaluate
its impact using a Finch experiment.

BUG= 487937 , 614983 

Review-Url: https://codereview.chromium.org/2014183002
Cr-Commit-Position: refs/heads/master@{#396428}
(cherry picked from commit 5fb28c944ab8cec3e7b1ab0ca866fbc7e242717f)

Review URL: https://codereview.chromium.org/2028563002 .

Cr-Commit-Position: refs/branch-heads/2743@{#137}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/30eaebb30490917efb80e7ebd4a82be301efb98b/content/child/runtime_features.cc
[modify] https://crrev.com/30eaebb30490917efb80e7ebd4a82be301efb98b/content/public/common/content_features.cc
[modify] https://crrev.com/30eaebb30490917efb80e7ebd4a82be301efb98b/content/public/common/content_features.h
[modify] https://crrev.com/30eaebb30490917efb80e7ebd4a82be301efb98b/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/30eaebb30490917efb80e7ebd4a82be301efb98b/third_party/WebKit/public/web/WebRuntimeFeatures.h

Sign in to add a comment