New issue
Advanced search Search tips

Issue 614963 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Migrate tests in the blink mediastream module to testharness

Project Member Reported by guidou@chromium.org, May 26 2016

Issue description

Tests currently use the older js-test.js framework, but testharness is the preferred way to write tests now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4e727c88c254a9d5a04432f1b540321bc85c137

commit c4e727c88c254a9d5a04432f1b540321bc85c137
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Aug 26 18:01:12 2016

Convert RTCPeerConnection-ice test from js-test.js to testharness.js

(This is my first CL so please let me know if I'm doing something wrong)

BUG=614963

Review-Url: https://codereview.chromium.org/2273363004
Cr-Commit-Position: refs/heads/master@{#414747}

[delete] https://crrev.com/4c369070c3e89056b3a90074315ac91b960862bf/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-expected.txt
[modify] https://crrev.com/c4e727c88c254a9d5a04432f1b540321bc85c137/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9f0606af0e7f6968c15e94dcd31f2e2053b948

commit ab9f0606af0e7f6968c15e94dcd31f2e2053b948
Author: jeffcarp <jeffcarp@chromium.org>
Date: Mon Aug 29 16:59:05 2016

Convert RTCIceCandidate.html from js-test to testharness.js

Trying to look for patterns we can potentially use for auto-converting these tests. See https://docs.google.com/a/google.com/document/d/1Ejzic4va3B0jam7D0AkrLbmhE57ZD06oeCZnSSiiTl8/edit?usp=sharing for what we've come up with so far.

BUG=614963

Review-Url: https://codereview.chromium.org/2286833002
Cr-Commit-Position: refs/heads/master@{#415020}

[delete] https://crrev.com/0795e5640c5fde7e1e83b3797f6a474a84065ea0/third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate-expected.txt
[modify] https://crrev.com/ab9f0606af0e7f6968c15e94dcd31f2e2053b948/third_party/WebKit/LayoutTests/fast/peerconnection/RTCIceCandidate.html

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2ed59f295442d8ede52791b6c21a5a0225d96c

commit 7e2ed59f295442d8ede52791b6c21a5a0225d96c
Author: jeffcarp <jeffcarp@chromium.org>
Date: Tue Aug 30 21:20:52 2016

Add more appropriate assert_unreached to RTCPeerConnection-ice test

BUG=614963

Review-Url: https://codereview.chromium.org/2289183003
Cr-Commit-Position: refs/heads/master@{#415429}

[modify] https://crrev.com/7e2ed59f295442d8ede52791b6c21a5a0225d96c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c961c0712e93b1c0c7a559415f71e838390ff6

commit f2c961c0712e93b1c0c7a559415f71e838390ff6
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Sep 09 19:10:16 2016

Refactor async_test in RTCPeerConnection-ice layout test

In https://codereview.chromium.org/2273363004/ qyearsley pointed out that this test wasn't running in the browser. This refactors the test to pass a function argument to async_test. I was hoping to solve the browser problem via this refactor, but it is still unsolved.

BUG=614963

Review-Url: https://codereview.chromium.org/2316573004
Cr-Commit-Position: refs/heads/master@{#417659}

[modify] https://crrev.com/f2c961c0712e93b1c0c7a559415f71e838390ff6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html

Comment 7 by guidou@chromium.org, Mar 13 2018

Labels: -Type-Feature Type-Task

Sign in to add a comment