Spacing issue is observed between button and text box in chrome://translate-internals.
Reported by
lpa...@etouch.net,
May 26 2016
|
|||
Issue descriptionChrome Version: 52.0.2743.10 18f7321a2c4403368e9e5e53f5396ede2d60b2f7-refs/branch-heads/2743@{#70} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS) Steps: 1. Launch chrome and navigate to chrome://translate-internals/ 2. Observe the spacing between the 'update' button and the text box under 'Override Variations Country' Actual: No space seen between the button and text box. Expected: Proper spacing should be seen between button and text box. This is a non regression issue seen from M-52 build no. (52.0.2716.0) Change-log URL: https://chromium.googlesource.com/chromium/src/+log/52.0.2715.0..52.0.2716.0?pretty=fuller&n=10000 Suspecting: r389501 Note: Same works fine in Mac OS.
,
Oct 5 2016
Issue is still reproducible on win10 chrome canary version 55.0.2880.4 hamelphi@, Could you please take a look at this
,
Oct 5 2016
,
Oct 5 2016
I am on it.
,
Oct 5 2016
https://codereview.chromium.org/2396963002/ fixes this on linux. I don't have access to windows or mac machines to test it though. I attached screenshots from before and after the patch on my linux machine.
,
Oct 5 2016
Re-sending the 'after' image.
,
Oct 12 2016
I changed the css a bit to control at the pixel level. It looks like adding a single pixel of margin does the job. Here is the new before and after.
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4168a20e872bf472b0febb413d625d39ef0ee6d0 commit 4168a20e872bf472b0febb413d625d39ef0ee6d0 Author: hamelphi <hamelphi@chromium.org> Date: Thu Oct 13 15:33:40 2016 Fix button spacing for overriding variations country. BUG= 614961 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2396963002 Cr-Commit-Position: refs/heads/master@{#425039} [modify] https://crrev.com/4168a20e872bf472b0febb413d625d39ef0ee6d0/chrome/browser/resources/translate_internals/translate_internals.css
,
Oct 17 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Jul 8 2016