WPT: Stop adding display:none to class=”instructions” elements |
|||
Issue descriptionWe add display:none to elements with class="instructions". * It's completely unnecessary for testharness.js tests. Our testharnessreport.js removes such elements regardless of display:none. * It might be unnecessary for reference tests if the element doesn't occupy large space.
,
Jun 8 2016
Kent, was this fixed by https://codereview.chromium.org/2020943002?
,
Jun 8 2016
> Kent, was this fixed by https://codereview.chromium.org/2020943002? It fixed this only for JS tests. Reftests still have this modifications.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a9a90ee23589defe4aad1fa76b33c64ccd445b4 commit 3a9a90ee23589defe4aad1fa76b33c64ccd445b4 Author: raikiri <raikiri@google.com> Date: Wed Jun 22 02:27:48 2016 Removed command to add display:none to class="instructions" elements BUG= 614956 Review-Url: https://codereview.chromium.org/2081113005 Cr-Commit-Position: refs/heads/master@{#401173} [modify] https://crrev.com/3a9a90ee23589defe4aad1fa76b33c64ccd445b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py [modify] https://crrev.com/3a9a90ee23589defe4aad1fa76b33c64ccd445b4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
,
Jun 27 2016
This should now be done for all tests; it turns out that adding class="instructions" wasn't necessary, apparently.
,
Jul 13 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 30 2016