New issue
Advanced search Search tips

Issue 614955 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 663773



Sign in to add a comment

WPT: Stop adding -webkit- prefix to CSS properties

Project Member Reported by tkent@chromium.org, May 26 2016

Issue description

update-w3c-deps adds "-webkit-" to CSS properties which Blink has only prefixed one.  We can avoid this by implementing unprefixed properties in a runtime flag enabled only in layout test.

Here is the list of such CSS properties at this moment.  However, they don't appear in web-platform-tests.

app-region
appearance
border-after
border-after-color
border-after-style
border-after-width
border-before
border-before-color
border-before-style
border-before-width
border-end
border-end-color
border-end-style
border-end-width
border-horizontal-spacing
border-start
border-start-color
border-start-style
border-start-width
border-vertical-spacing
box-align
box-decoration-break
box-direction
box-flex
box-flex-group
box-lines
box-ordinal-group
box-orient
box-pack
box-reflect
column-break-after
column-break-before
column-break-inside
font-size-delta
font-smoothing
highlight
hyphenate-character
line-break
line-clamp
locale
logical-height
logical-width
margin-after
margin-after-collapse
margin-before
margin-before-collapse
margin-bottom-collapse
margin-collapse
margin-end
margin-start
margin-top-collapse
mask-box-image
mask-box-image-outset
mask-box-image-repeat
mask-box-image-slice
mask-box-image-source
mask-box-image-width
mask-clip
mask-composite
mask-image
mask-origin
mask-position
mask-position-x
mask-position-y
mask-repeat
mask-repeat-x
mask-repeat-y
mask-size
max-logical-height
max-logical-width
min-logical-height
min-logical-width
padding-after
padding-before
padding-end
padding-start
perspective-origin-x
perspective-origin-y
print-color-adjust
rtl-ordering
ruby-position
tap-highlight-color
text-combine
text-decorations-in-effect
text-emphasis
text-emphasis-color
text-emphasis-position
text-emphasis-style
text-fill-color
text-security
text-stroke
text-stroke-color
text-stroke-width
transform-origin-x
transform-origin-y
transform-origin-z
user-drag
user-modify
user-select

 
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49299d795e825ce8ce25b60b14ef10b8de32a25

commit f49299d795e825ce8ce25b60b14ef10b8de32a25
Author: tkent <tkent@chromium.org>
Date: Mon May 30 04:24:28 2016

update-w3c-deps: Do not modify testharness tests.

update-w3c-deps modified testharness tests in the following ways:

* Prefix CSS properties
  Add "-webkit-" prefixes to CSS properties which we support only prefixed version.
  This modification didn't affect any testharness tests.
  If new tests need such CSS properties, we should implement such properties.

* Add display:none to elements with class="instructions"
  Because our testharnessreport.js removes all of elements in the BODY, this
  modification isn't necessary.

So, we may just copy testharness tests without any modifications.

* wpt/dom/nodes/MutationObserver-characterData.html
* wpt/html/syntax/serializing-html-fragments/serializing.html
  This CL changes the behavior of these tests because they are sensitive for
  comment data, and our test converter has a bug of comment serialization.

BUG= 614955 ,  614956 

Review-Url: https://codereview.chromium.org/2020943002
Cr-Commit-Position: refs/heads/master@{#396673}

[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-circle-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-ellipse-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-ellipse-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-ellipse-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-inset-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside-invalid-inset-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-box-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-004.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-005.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-006.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-007.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-008.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-009.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-010.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-011.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-computed-shape-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-computed-shape-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-004.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-005.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-006.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-007.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-008.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-009.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-010.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-011.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-004.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-005.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-006.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-007.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-008.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-009.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-004.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-005.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-006.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-box-pair-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-inherit-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-initial-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-none-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-notation-000.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-010.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-011.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-013.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-014.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-015.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-016.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-017.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-018.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-shapes-1/spec-examples/shape-outside-019.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-snap-size-1/snap-width-parsing-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001a.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001b.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001c.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001d.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001e.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001f.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001g.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001h.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001i.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001j.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001k.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001l.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001m.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001n.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001o.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001p.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001q.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001r.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001s.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001t.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001u.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001v.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001w.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001x.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/abort-in-initial-upgradeneeded.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/close-in-upgradeneeded.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/cursor-overloads.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/idbkeyrange_incorrect.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/key_invalid.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/key_valid.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/keyorder.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/keypath.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/keypath_invalid.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/string-list-ordering.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/collections/HTMLCollection-supported-property-indices.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/collections/HTMLCollection-supported-property-names.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/DOMImplementation-createHTMLDocument.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-adoptNode.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-constructor.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-doctype.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-getElementById.html
[delete] https://crrev.com/c4ccc6b681aba1870c8aed69b3a18201ee97ddd4/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/MutationObserver-characterData-expected.txt
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/MutationObserver-characterData.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Node-compareDocumentPosition.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Node-contains.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Node-lookupPrefix.xhtml
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/getElementsByClassName-14.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/getElementsByClassName-28.htm
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-acceptNode-filter.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-basic.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-currentNode.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-previousNodeLastChildReject.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-traversal-reject.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-traversal-skip-most.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-traversal-skip.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/dom/traversal/TreeWalker-walking-outside-a-tree.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/encoding/big5-encoder.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/encoding/gb18030-encoder.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/encoding/gbk-encoder.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/encoding/iso-2022-jp-encoder.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/001.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/002.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/003.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/004.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/005.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/scroll-to-fragid/006.html
[modify] https://crrev.com/f49299d795e825ce8ce25b60b14ef10b8de32a25/t

Comment 3 by tkent@chromium.org, May 30 2016

I found adding unprefixed "text-emphasis" wasn't a trivial change. We don't support multiple CSS property aliases and we already have epub-text-emphasis.

Kent: is this bug partially fixed, but not fully fixed because using unprefixed text-emphasis is a non-trivial change currently?

Comment 5 by tkent@chromium.org, Jun 8 2016

I stopped this modification for JS tests by #2 because this didn't affect JS tests at all.
This is not fixed at all for reftests.  What we should to do is only implementing unprefixed text-emphasis.

Comment 6 by tkent@chromium.org, Nov 17 2016

Blockedon: 666433
Blocking: 663773
Components: Blink>Infra>Predictability
Components: -Blink>Infra
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65

commit 6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Jan 27 03:35:19 2017

Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG= 677884 ,  614955 

Review-Url: https://codereview.chromium.org/2633223003
Cr-Commit-Position: refs/heads/master@{#446574}

[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/css_properties.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_names.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_style_builder.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_style_shorthands.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/scripts.gni
[delete] https://crrev.com/8607d9dbd5cc0fc0af61580e7af0f92509bec5d0/third_party/WebKit/Source/core/css/CSSProperties.in
[add] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/scripts/build/generate_supported_css.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/scripts/gulp/gulpfile.js
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934

commit c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934
Author: kojii <kojii@chromium.org>
Date: Tue Feb 28 09:57:21 2017

Add unprefixed -webkit-line-break as an alias to import csswg-test

This patch adds unprefixed line-break as an alias to -webkit-line-break.

Currently, the -webkit-line-break is parsed but is not honored. This is
a preparation step to import csswg-test for the 'line-break' property.

To import csswg-test, adding unprefixed aliases is recommended in
 crbug.com/614955 .

BUG= 306730 ,  614955 

Review-Url: https://codereview.chromium.org/2725543002
Cr-Commit-Position: refs/heads/master@{#453559}

[modify] https://crrev.com/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934/tools/metrics/histograms/histograms.xml

Cc: tkent@chromium.org kojii@chromium.org jeffcarp@chromium.org foolip@chromium.org
In the past, we had decided we wanted to unprefix all properties in Blink (and fix bug 666433) before stopping adding of prefixes when importing tests -- but another option would be to immediately stop prefixing properties and modifying tests on import.

This may cause a few extra tests to fail, but it would likely be very few; note that the css-text-decor-3/text-emphasis-* are already mostly marked as failing (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?l=977).

The advantage of doing this immediately even though Blink still has some prefixed properties is that if we stop doing any conversions ( issue 663773 ), then we can start auto-exporting any changes in wpt/css.

Comment 12 by kojii@chromium.org, Mar 30 2017

Wrote in different bug but I support the idea in #11. The benefits to stop prefixing wins over running imported text-emphasis-* tests.
This is great, thanks!
Owner: qyears...@chromium.org
Status: Fixed (was: Available)
:-D
Blockedon: -666433
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment