Issue metadata
Sign in to add a comment
|
Regression:Permission bubble appears misplaced after clicking on fullscreen icon of game.
Reported by
vku...@etouch.net,
May 26 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2743.10 18f7321a2c4403368e9e5e53f5396ede2d60b2f7-refs/branch-heads/2743@{#70} (64-bit) OS:Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1.Launch chrome and install 'muffin knight' app from https://chrome.google.com/webstore/detail/ngcgpajmidlcgbkpjaopbcglkjepkbaa 2.Click on app once the permission bubble appears click on fullscreen icon from bottom right of game,observe the bubble. Actual: Permission bubble appears misplaced after clicking on fullscreen icon of game. Expected Permission bubble should be properly displayed after clicking on fullscreen icon of game. This is a regression issue broken in 'M52' and will soon update other info.
,
May 26 2016
Marking the above issue as RB-Stable as this issue Needs to be fixed before M52 hits to stable. Thank you!
,
May 26 2016
I'm confused - the movies seem to be for another bug?
,
May 27 2016
With response to comment #3: Please find the attached screencast thank you
,
May 31 2016
Able to reproduce the issue on Mac OS 10.11.5 using latest chrome canary M53-53.0.2751.0. benwells@ - Any update on this bug? Could you please have a look on it. Thanks!
,
Jun 1 2016
Sorry about the silence ... uploading a fix for review now.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c657c1722cfc92eb307341859a294ff64d6d40a commit 2c657c1722cfc92eb307341859a294ff64d6d40a Author: benwells <benwells@chromium.org> Date: Thu Jun 02 06:33:02 2016 Correctly move permission bubbles after entering / exiting fullscreen. When full screen is entered or exited the position of the bubble arrow may need to be updated. This change updates the location, and ensures the bubble is repainted when the arrow location is updated. BUG= 614928 Review-Url: https://codereview.chromium.org/2036503002 Cr-Commit-Position: refs/heads/master@{#397314} [modify] https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a/chrome/browser/ui/cocoa/info_bubble_view.mm [modify] https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
,
Jun 2 2016
Will request a merge after testing in canary.
,
Jun 3 2016
,
Jun 3 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe commit 71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe Author: Ben Wells <benwells@chromium.org> Date: Fri Jun 03 05:59:59 2016 Correctly move permission bubbles after entering / exiting fullscreen. When full screen is entered or exited the position of the bubble arrow may need to be updated. This change updates the location, and ensures the bubble is repainted when the arrow location is updated. BUG= 614928 Review-Url: https://codereview.chromium.org/2036503002 Cr-Commit-Position: refs/heads/master@{#397314} (cherry picked from commit 2c657c1722cfc92eb307341859a294ff64d6d40a) Review URL: https://codereview.chromium.org/2036973002 . Cr-Commit-Position: refs/branch-heads/2743@{#201} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe/chrome/browser/ui/cocoa/info_bubble_view.mm [modify] https://crrev.com/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
,
Jun 8 2016
Rechecked this on chrome version 52.0.2743.33 on MAC 10.11.5, now after navigating to the full screen mode the Bubble appears in the middle of the screen and once switching back to the normal mode the bubble is repainted back to the original position. Attached screenshot for the full screen mode. Is this the intentional fix. @benwells: Request you to please confirm the same. Will add TE-verified labels if this is intended. Thanks.!
,
Jun 8 2016
Yes, that's intended.
,
Jun 9 2016
Thanks for confirming, Adding TE-Verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, May 26 2016Owner: benwells@chromium.org
Status: Assigned (was: Unconfirmed)
4.5 MB
4.5 MB Download
4.3 MB
4.3 MB Download