New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Permission bubble appears misplaced after clicking on fullscreen icon of game.

Reported by vku...@etouch.net, May 26 2016

Issue description

Chrome Version:52.0.2743.10 18f7321a2c4403368e9e5e53f5396ede2d60b2f7-refs/branch-heads/2743@{#70} (64-bit)
OS:Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1.Launch chrome and install 'muffin knight' app from https://chrome.google.com/webstore/detail/ngcgpajmidlcgbkpjaopbcglkjepkbaa
2.Click on app once the permission bubble appears click on fullscreen icon from bottom right of game,observe the bubble.

Actual: Permission bubble appears misplaced after clicking on fullscreen icon of game.

Expected Permission bubble should be properly displayed after clicking on fullscreen icon of game.

This is a regression issue broken in 'M52' and will soon update other info.

 

Comment 1 by vku...@etouch.net, May 26 2016

Labels: hasbisect
Owner: benwells@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 52.0.2720.0
Bad Build:  52.0.2721.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/f337675ea340b9d2070e773ec4c14a8e179c78ab..070786c56dafefdaa631a66c4248e7689e91b0fc?pretty=fuller&n=10

Suspecting: r390596

Note: Issue not seen on Win & Linux OS.
Actual_Permission.mov
4.5 MB Download
Expected_Permission.mov
4.3 MB Download
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this issue Needs to be fixed before M52 hits to stable.

Thank you!
I'm confused - the movies seem to be for another bug?

Comment 4 by vku...@etouch.net, May 27 2016

With response to comment #3:

Please find the attached screencast

thank you
Actual_App.mov
4.1 MB Download
Expected_App.mov
4.7 MB Download
Able to reproduce the issue on Mac OS 10.11.5 using latest chrome canary M53-53.0.2751.0. 

benwells@ - Any update on this bug? Could you please have a look on it.

Thanks!
Status: Started (was: Assigned)
Sorry about the silence ... uploading a fix for review now.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c657c1722cfc92eb307341859a294ff64d6d40a

commit 2c657c1722cfc92eb307341859a294ff64d6d40a
Author: benwells <benwells@chromium.org>
Date: Thu Jun 02 06:33:02 2016

Correctly move permission bubbles after entering / exiting fullscreen.

When full screen is entered or exited the position of the bubble arrow
may need to be updated. This change updates the location, and ensures
the bubble is repainted when the arrow location is updated.

BUG= 614928 

Review-Url: https://codereview.chromium.org/2036503002
Cr-Commit-Position: refs/heads/master@{#397314}

[modify] https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a/chrome/browser/ui/cocoa/info_bubble_view.mm
[modify] https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Status: Fixed (was: Started)
Will request a merge after testing in canary.
Labels: Merge-Request-52

Comment 10 by tin...@google.com, Jun 3 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe

commit 71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe
Author: Ben Wells <benwells@chromium.org>
Date: Fri Jun 03 05:59:59 2016

Correctly move permission bubbles after entering / exiting fullscreen.

When full screen is entered or exited the position of the bubble arrow
may need to be updated. This change updates the location, and ensures
the bubble is repainted when the arrow location is updated.

BUG= 614928 

Review-Url: https://codereview.chromium.org/2036503002
Cr-Commit-Position: refs/heads/master@{#397314}
(cherry picked from commit 2c657c1722cfc92eb307341859a294ff64d6d40a)

Review URL: https://codereview.chromium.org/2036973002 .

Cr-Commit-Position: refs/branch-heads/2743@{#201}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe/chrome/browser/ui/cocoa/info_bubble_view.mm
[modify] https://crrev.com/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Rechecked this on chrome version 52.0.2743.33 on MAC 10.11.5, now after navigating to the full screen mode the Bubble appears in the middle of the screen and once switching back to the normal mode the bubble is repainted back to the original position.

Attached screenshot for the full screen mode. Is this the intentional fix.

@benwells: Request you to please confirm the same. Will add TE-verified labels if this is intended.

Thanks.!
Screen Shot 2016-06-08 at 2.36.18 PM.png
3.4 MB View Download
Yes, that's intended.
Labels: -Needs-Feedback TE-Verified-M52 TE-Verified-52.0.2743.33
Thanks for confirming, Adding TE-Verified labels.

Sign in to add a comment