DevTools: can't escape with Esc from Settings (Devices, Throttling tabs) |
|||
Issue description1) Open DevTools, go to settings dialog 2) Click on either Devices or Throttling tabs 3) Press 'Esc' 4) Nothing happens What is expected? For all the other tabs in settings (Preferences, Workspace...etc), the Esc shortcut correctly closes the dialog.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ad9d6295756dbc10cbfa1c4563f1dd477343b15 commit 6ad9d6295756dbc10cbfa1c4563f1dd477343b15 Author: luoe <luoe@chromium.org> Date: Thu Jun 30 23:33:28 2016 DevTools: fix deepActiveElement and focus on Dialog when document blurs - Before, deepActiveElement() returned the deepest shadow root's activeElement. Now, it returns the deepest activeElement (which may not be in the deepest shadow root) - Buttons 'Add pattern', 'Add custom device', 'Add custom profile' in the Blackboxing, Devices, and Throttling settings tabs now have default focus - Now that Dialog's keydown handler is on the body, pressing Esc now closes the settings dialog, even after the document blurs BUG= 614902 Review-Url: https://codereview.chromium.org/2094873002 Cr-Commit-Position: refs/heads/master@{#403337} [modify] https://crrev.com/6ad9d6295756dbc10cbfa1c4563f1dd477343b15/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js [modify] https://crrev.com/6ad9d6295756dbc10cbfa1c4563f1dd477343b15/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js [modify] https://crrev.com/6ad9d6295756dbc10cbfa1c4563f1dd477343b15/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
,
Jul 1 2016
,
Jul 7 2016
Verified the above issue on All-OS(Windows, Mac 10.11.5 & Ubuntu 14.04) with chrome version '53.0.2785.8' & pressing esc opened dialog box is getting closed under settings. hence marking the same as TE-Verified-53.0.2785.8. Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by l...@chromium.org
, Jun 23 2016