New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614892 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: May 2016
Cc:
h...@chromium.org
█ dskiba@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

clang ipc plugin test started failing on clang tot bots

Project Member Reported by thakis@chromium.org, May 26 2016 
e.g. here:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/builds/3268/steps/gclient%20runhooks/logs/stdio

expected:
ipc.cpp:324:28: error: [chromium-ipc] IPC::WriteParam() is called on blacklisted type 'long'.
  IPC::WriteParam(nullptr, p.get<long>()); // ERROR
                           ^

actual:
ipc.cpp:324:30: error: [chromium-ipc] IPC::WriteParam() is called on blacklisted type 'long'.
  IPC::WriteParam(nullptr, p.get<long>()); // ERROR
                             ^

Looks like the source location is a bit more precise now. We can probably just rebase the expectations file?

Comment 2 by thakis@chromium.org, May 26 2016

Cc: dskiba@chromium.org
Owner: thakis@chromium.org
Status: Started (was: Untriaged)
actually, let me just rebase that
Project Member

Comment 3 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f99c178e15f6db8e3c5b057acdefd657632af0c

commit 0f99c178e15f6db8e3c5b057acdefd657632af0c
Author: thakis <thakis@chromium.org>
Date: Thu May 26 01:13:14 2016

rebase clang ipc plugin test after clang r270775.

BUG= 614892 
TBR=hans
NOTRY=true

Review-Url: https://codereview.chromium.org/2015513004
Cr-Commit-Position: refs/heads/master@{#396072}

[modify] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/tools/clang/plugins/tests/ipc.txt
►

Sign in to add a comment