New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Blimp fyi bot broken on Build # 121.

Project Member Reported by haibinlu@chromium.org, May 26 2016

Issue description

Status: Fixed (was: Assigned)
Reverted a CL.

https://codereview.chromium.org/2008283004/
Project Member

Comment 2 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/086802955ffbe67f0a2de987822ae8d18dd5353d

commit 086802955ffbe67f0a2de987822ae8d18dd5353d
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri May 27 01:57:30 2016

Reland: Added a debug info UI for Blimp

Added a menu option in toolbar to show/hide debug info. When enabled,
an overlay debug UI would be shown on the bottom left of the screen
showing number of commits, and kilobytes sent and received by the client.
This data is reset when the user moves away or is redirected to a new
page.

BUG= 594423 ,  614888 
TBR=vmpstr@chromium.org

Original CL: https://codereview.chromium.org/1962393004/
Revert CL: https://codereview.chromium.org/2008283004/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2019463002
Cr-Commit-Position: refs/heads/master@{#396351}

[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/BUILD.gn
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/res/layout/blimp_main.xml
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/res/layout/debug_stats_overlay.xml
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/BUILD.gn
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection.h
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics.cc
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics.h
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_socket_connection.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_socket_connection.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_client_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_client_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_transport_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_impl.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_unittest.cc

Labels: Archive-Blimp

Sign in to add a comment