WebUI History is broken due to refactoring of resource files in ( https://codereview.chromium.org/1919183005) that did not propagate to the ios fork
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd199135e935f3c9ce7be0e9954382ab0d2140e9 commit cd199135e935f3c9ce7be0e9954382ab0d2140e9 Author: jyquinn <jyquinn@chromium.org> Date: Thu May 26 21:15:25 2016 Update iOS WebUI History to use icon.js Use icon.js in iOS WebUI History, which was factored out of util.js in https://codereview.chromium.org/1919183005 BUG= 614871 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2014743002 Cr-Commit-Position: refs/heads/master@{#396283} [modify] https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9/ios/chrome/app/resources/history/history.html [modify] https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9/ios/chrome/app/resources/history/history.js [modify] https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9/ios/chrome/app/resources/history/other_devices.js [modify] https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9/ios/web/webui/resources/web_ui_favicons.js [modify] https://crrev.com/cd199135e935f3c9ce7be0e9954382ab0d2140e9/ui/webui/resources/js/icon.js
Your change meets the bar and is auto-approved for M52 (branch: 2743)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f57aff4a7a0e2799360cfde196eb84c62fefe7ae commit f57aff4a7a0e2799360cfde196eb84c62fefe7ae Author: Jackie Quinn <jyquinn@chromium.org> Date: Tue May 31 20:53:49 2016 Update iOS WebUI History to use icon.js Use icon.js in iOS WebUI History, which was factored out of util.js in https://codereview.chromium.org/1919183005 BUG= 614871 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2014743002 Cr-Commit-Position: refs/heads/master@{#396283} (cherry picked from commit cd199135e935f3c9ce7be0e9954382ab0d2140e9) Review URL: https://codereview.chromium.org/2026903002 . Cr-Commit-Position: refs/branch-heads/2743@{#148} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/f57aff4a7a0e2799360cfde196eb84c62fefe7ae/ios/chrome/app/resources/history/history.html [modify] https://crrev.com/f57aff4a7a0e2799360cfde196eb84c62fefe7ae/ios/chrome/app/resources/history/history.js [modify] https://crrev.com/f57aff4a7a0e2799360cfde196eb84c62fefe7ae/ios/chrome/app/resources/history/other_devices.js [modify] https://crrev.com/f57aff4a7a0e2799360cfde196eb84c62fefe7ae/ios/web/webui/resources/web_ui_favicons.js [modify] https://crrev.com/f57aff4a7a0e2799360cfde196eb84c62fefe7ae/ui/webui/resources/js/icon.js
Comment 1 by pkl@chromium.org
, May 26 2016