New issue
Advanced search Search tips

Issue 614869 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: POST form resubmission is affected

Reported by teo8...@gmail.com, May 25 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36

Steps to reproduce the problem:
Just see my comment #10 at: https://bugs.chromium.org/p/chromium/issues/detail?id=71024#c10

What is the expected behavior?
Besides the fact that the behavior is buggy, the way Chrome does its http requests shouldn't change the slightest bit regardless of whether the DevTools are open or not. There should be a rock-solid guarantee of that at the deepest conceivable level.
If opening the DevTools changes the behavior, it defeats their very purpose.

What went wrong?
the behavior changes depending on whether or not you have DevTools open.

Did this work before? N/A 

Chrome version: 50.0.2661.102  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

Please keep this separate from issue 71024. This one is about DevTools altering the behavior, not about that specific buggy behavior (which is buggy both with and without DevTools, though in different ways)
 
Components: -Platform>DevTools Platform>DevTools>Network
Labels: -OS-Linux OS-All
Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by teo8...@gmail.com, May 26 2016

Sorry, typo in the title: by "webtools" I obviously meant devtools
Summary: Behavior of requests changes with vs without devtools (was: Behavior of requests changes with vs without webtools)
Owner: eostroukhov@chromium.org
Summary: DevTools: POST form resubmission is affected (was: Behavior of requests changes with vs without devtools)

Comment 5 by teo8...@gmail.com, Dec 2 2017

The response from the server doesn't need to be a 500 in order to observe the issue with DevTools: any kind of response will reproduce the issue (unlike issue 71024 without devtools). Tested and reproduced with 500, 200 and 403 responses.

When devtools are open, Chrome systematically resend a POST request without prompt when you hit the Refresh button.

You do realize this is a security issue unfixed since 2011, right?
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddbc46dff7954067faa1da9afba766446752a8c4

commit ddbc46dff7954067faa1da9afba766446752a8c4
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Sat Jan 20 00:11:01 2018

DevTools: prefer reload in browser

This performs reload in the browser, to make it more consistent with
regular reload expirience (e.g. warning about resubmitting POST
navigation would be shown now).

Bug: 614869
Change-Id: I90d36eb389b04cc41f5ab7524cbc6209bf100412
Reviewed-on: https://chromium-review.googlesource.com/860575
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530678}
[modify] https://crrev.com/ddbc46dff7954067faa1da9afba766446752a8c4/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/ddbc46dff7954067faa1da9afba766446752a8c4/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/ddbc46dff7954067faa1da9afba766446752a8c4/content/browser/devtools/protocol_config.json

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3511e3b146f4f024c292fb2003b9e7315365a11d

commit 3511e3b146f4f024c292fb2003b9e7315365a11d
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Mon Jan 22 21:32:02 2018

Revert "DevTools: prefer reload in browser"

This reverts commit ddbc46dff7954067faa1da9afba766446752a8c4.

Reason for revert: breaks DevTools debugging

Original change's description:
> DevTools: prefer reload in browser
> 
> This performs reload in the browser, to make it more consistent with
> regular reload expirience (e.g. warning about resubmitting POST
> navigation would be shown now).
> 
> Bug: 614869
> Change-Id: I90d36eb389b04cc41f5ab7524cbc6209bf100412
> Reviewed-on: https://chromium-review.googlesource.com/860575
> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530678}

TBR=dgozman@chromium.org,eostroukhov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 614869
Change-Id: I3a305d6f364179c5591b1873cfc129f8bcf6fc49
Reviewed-on: https://chromium-review.googlesource.com/879120
Reviewed-by: Eugene Ostroukhov <eostroukhov@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531002}
[modify] https://crrev.com/3511e3b146f4f024c292fb2003b9e7315365a11d/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/3511e3b146f4f024c292fb2003b9e7315365a11d/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/3511e3b146f4f024c292fb2003b9e7315365a11d/content/browser/devtools/protocol_config.json

Status: Assigned (was: Fixed)
Owner: jarhar@chromium.org
Cc: l...@chromium.org
 Issue 892659  has been merged into this issue.

Sign in to add a comment