Issue metadata
Sign in to add a comment
|
Download failed notification is shown without filename |
||||||||||||||||||
Issue descriptionDevice name: Nexus 6P Application version: M52 Steps to reproduce: (1) Disable "use system download manager" in chrome://flags (2) Download some file (3) while download starts, immediately kill chrome by swiping it away from recent apps drawer (4) resume the download from notification Expected result: Download fails with a notification showing the filename Actual result: no filename is shown The problem is that if chrome is killed immediately after download, the download history may not yet be written. When resuming the download, we pass the GUID to the download manager, and it won't be able to find the download. However,since the download manager doesn't have know the download, it will not be able to provide the filename to notification service. Thus we need to read the file name from shared prefs.
,
May 26 2016
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c916d5295b2c636581db6271c242e35bf7394411 commit c916d5295b2c636581db6271c242e35bf7394411 Author: qinmin <qinmin@chromium.org> Date: Thu May 26 23:46:24 2016 Fix an issue that filename is missing in download failure notification When resuming a download, it is possible that the download is not in history db. In this case, native code won't be able to provide the filename. We need to get the file name from sharedpreferences BUG= 614867 Review-Url: https://codereview.chromium.org/2007983007 Cr-Commit-Position: refs/heads/master@{#396321} [modify] https://crrev.com/c916d5295b2c636581db6271c242e35bf7394411/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
May 26 2016
,
May 26 2016
,
May 27 2016
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
,
May 27 2016
Merge is approved for M51 branch 2704. Please merge ASAP.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51af006325a102d9a29830fe98dff32ed02824b4 commit 51af006325a102d9a29830fe98dff32ed02824b4 Author: Min Qin <qinmin@chromium.org> Date: Fri May 27 19:20:00 2016 Fix an issue that filename is missing in download failure notification When resuming a download, it is possible that the download is not in history db. In this case, native code won't be able to provide the filename. We need to get the file name from sharedpreferences TBR=michaelbai@chromium.org BUG= 614867 Review-Url: https://codereview.chromium.org/2007983007 Cr-Commit-Position: refs/heads/master@{#396321} (cherry picked from commit c916d5295b2c636581db6271c242e35bf7394411) Review URL: https://codereview.chromium.org/2019793002 . Cr-Commit-Position: refs/branch-heads/2704@{#668} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/51af006325a102d9a29830fe98dff32ed02824b4/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66befcc7574b14a10bda95137669f02274d44e4a commit 66befcc7574b14a10bda95137669f02274d44e4a Author: Min Qin <qinmin@chromium.org> Date: Tue May 31 18:57:05 2016 Fix an issue that filename is missing in download failure notification When resuming a download, it is possible that the download is not in history db. In this case, native code won't be able to provide the filename. We need to get the file name from sharedpreferences TBR=michaelbai@chromium.org BUG= 614867 Review-Url: https://codereview.chromium.org/2007983007 Cr-Commit-Position: refs/heads/master@{#396321} (cherry picked from commit c916d5295b2c636581db6271c242e35bf7394411) Review URL: https://codereview.chromium.org/2019793002 . Cr-Commit-Position: refs/branch-heads/2704@{#668} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} (cherry picked from commit 51af006325a102d9a29830fe98dff32ed02824b4) Review URL: https://codereview.chromium.org/2026003002 . Cr-Commit-Position: refs/branch-heads/2743@{#139} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/66befcc7574b14a10bda95137669f02274d44e4a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
May 31 2016
,
Jun 2 2016
Verified in M52-52.0.2743.25 |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by qin...@chromium.org
, May 25 2016