New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614852 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

12.5%-56.9% regression in blink_perf.layout at 395611:395672

Project Member Reported by m...@chromium.org, May 25 2016

Issue description

See the link to graphs below.
 

Comment 2 by m...@chromium.org, May 26 2016

Labels: -Pri-2 Pri-1
Owner: koten...@yandex-team.ru
Based on bisect results, suspecting this change was responsible:

commit	4d0d91ff393599cb9e605b10b09eb59983145cd4	
author	kotenkov <kotenkov@yandex-team.ru>	Tue May 24 17:24:49 2016
committer	Commit bot <commit-bot@chromium.org>	Tue May 24 17:25:56 2016
Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
Cc: danakj@chromium.org tkent@chromium.org thakis@chromium.org
It looks like that CHECK => RELEASE_ASSERT still causes some regression.

Components: Blink>WTF
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ab609c3dcf497cb08af396f552ca1c8c56e10a

commit 90ab609c3dcf497cb08af396f552ca1c8c56e10a
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri May 27 11:46:46 2016

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #3 id:40001 of https://codereview.chromium.org/1992873004/ )

Reason for revert:
12.5%-56.9% regression in blink_perf.layout at 395611:395672

Original issue's description:
> Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
>
> This is a reland of https://codereview.chromium.org/1840163002.
>
> Performance regressions were addressed in
> https://codereview.chromium.org/1937613002
> and https://codereview.chromium.org/1840163002.
>
> BUG= 596760 , 599867 
>
> Committed: https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4
> Cr-Commit-Position: refs/heads/master@{#395624}

TBR=haraken@chromium.org,yutak@chromium.org,tkent@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 596760 , 599867 , 614852 

Review-Url: https://codereview.chromium.org/2016223002
Cr-Commit-Position: refs/heads/master@{#396441}

[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/Partitions.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/AtomicString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringConcatenate.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/WTFString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h

Comment 6 by danakj@chromium.org, May 31 2016

Cc: brettw@chromium.org
On Windows only it looks like though.

Comment 7 by danakj@chromium.org, May 31 2016

Cc: brucedaw...@chromium.org

Comment 9 by tkent@chromium.org, Jun 23 2016

Components: -Blink>WTF Blink>Internals>WTF
Renaming Blink>WTF to Blink>Internals>WTF.

Status: Fixed (was: Assigned)
These metrics have recovered.

Sign in to add a comment