New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614844 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router WebUI] Scroll bar jumps when positioned at lowest point and clicked

Project Member Reported by dbbrooks@chromium.org, May 25 2016

Issue description

Component Extension: 5116.523.0.0					
Chrome: 52.0.2739.0					
Platform: Win and mac

On a network with many devices, where the scrollbar appears in the MR dialog, drag the scrollbar down to the lowest position, then click anywhere on the scrollbar. It jumps up and down.



 
Labels: Hotlist-Polish OS-Mac OS-Windows
Summary: [Media Router WebUI] Scroll bar jumps when positioned at lowest point and clicked (was: scroll bar jumps when at bottom and clicked on)
Repros from M51-M53.

Comment 3 by sko...@chromium.org, May 27 2016

Status: Available (was: Untriaged)

Comment 4 by sko...@chromium.org, Jun 22 2016

Labels: Hotlist-Fixit-PE2016
Owner: taku...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae

commit 0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae
Author: takumif <takumif@chromium.org>
Date: Thu Oct 06 00:01:01 2016

[MR UI] Add a wrapper div to the sink list and search results in the MR dialog

Instead of making the sink list/search results paper-menu contain its own scrollbar, we add a wrapper div around it that contains a scrollbar. This way, clicking on the scrollbar doesn't trigger the _onFocus() callback on the paper-menu that puts focus on the first element in the menu and messes up the scroll position.

BUG= 614844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2365743002
Cr-Commit-Position: refs/heads/master@{#423347}

[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/test/data/webui/media_router/media_router_container_filter_tests.js

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae

commit 0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae
Author: takumif <takumif@chromium.org>
Date: Thu Oct 06 00:01:01 2016

[MR UI] Add a wrapper div to the sink list and search results in the MR dialog

Instead of making the sink list/search results paper-menu contain its own scrollbar, we add a wrapper div around it that contains a scrollbar. This way, clicking on the scrollbar doesn't trigger the _onFocus() callback on the paper-menu that puts focus on the first element in the menu and messes up the scroll position.

BUG= 614844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2365743002
Cr-Commit-Position: refs/heads/master@{#423347}

[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/0ca3ddbeaed0c6f6ee0f2a488a03abdeb8c64cae/chrome/test/data/webui/media_router/media_router_container_filter_tests.js

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment