New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614806 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Material Design thinks the Splendid theme is a dark theme

Project Member Reported by shrike@chromium.org, May 25 2016

Issue description

Comment 1 by shrike@chromium.org, Jun 15 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5

commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5
Author: shrike <shrike@chromium.org>
Date: Thu Jun 16 16:24:12 2016

[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG= 614806 , 617993 

Review-Url: https://codereview.chromium.org/2068243002
Cr-Commit-Position: refs/heads/master@{#400168}

[modify] https://crrev.com/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5/chrome/browser/ui/cocoa/chrome_browser_window.mm

Comment 3 by shrike@chromium.org, Jun 16 2016

Labels: Merge-Request-52
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac OS 10.11.5 using chrome latest canary M53-53.0.2770.0 and observed there was no dark theme in the custom toolbar in adding splendid theme.

shrike@ - Could you please confirm it from your end as well is this is the expected behavior of this issue, Attaching screen-cast for reference. It will be helpful to verify this issue from Chrome-TE end

Thanks!
SplendidTheme.mp4
2.2 MB View Download

Comment 5 by tin...@google.com, Jun 17 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 6 by shrike@chromium.org, Jun 17 2016

When Chrome Mac thinks a custom theme is dark it draws the toolbar control icons in white instead of gray, and uses black for the omnibox dropdown background. From your screencast the icons are gray and the dropdown is white. so it does not consider the Splendid theme as being dark, which is correct.
shrike@, Please have the CL merged to M52 branch by EOD today so that it gets picked up for Beta Promotion scheduled next week.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 17 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75175ca5f6abba3c5d15cbbc1080ce8f5889a946

commit 75175ca5f6abba3c5d15cbbc1080ce8f5889a946
Author: Jayson Adams <shrike@chromium.org>
Date: Fri Jun 17 22:09:11 2016

[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG= 614806 , 617993 

Review-Url: https://codereview.chromium.org/2068243002
Cr-Commit-Position: refs/heads/master@{#400168}
(cherry picked from commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5)

Review URL: https://codereview.chromium.org/2077743004 .

Cr-Commit-Position: refs/branch-heads/2743@{#384}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/75175ca5f6abba3c5d15cbbc1080ce8f5889a946/chrome/browser/ui/cocoa/chrome_browser_window.mm

Comment 9 by shrike@chromium.org, Jun 17 2016

Status: Fixed (was: Started)
Labels: -Needs-Feedback TE-Verified-M52 TE-Verified-52.0.2743.49
Tested the issue on Mac 10.11.5 using 52.0.2743.49.Observed that icons are gray and the dropdown is white.
Please find attached screencast.

Marking it as TE-Verified.
614806.mp4
947 KB View Download

Sign in to add a comment