New issue
Advanced search Search tips

Issue 614803 link

Starred by 1 user
Status: Verified
Owner:
jdonnelly@chromium.org
Closed: May 2016
Cc:
se...@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autofill server cards and profiles have an incorrect modification_date of Now().

Project Member Reported by jdonnelly@chromium.org, May 25 2016 
As of https://codereview.chromium.org/1891903002/, the default value for modification_date in autofill entries is base::Time::Now(). This works for new entries and ones that are read in from the db and have this value set explicitly. But in the case of server profiles and cards, modification_date is not tracked nor set explicitly so these entries look like they were always just modified.

This behavior causes a problem for the upload feature which is interested in all profiles modified or used recently. Since the modification_date of server profiles is always Now(), they are considered even if the user hasn't used them any time recently.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/914445df51cdeae9a867061c32e3b9bbe8784078

commit 914445df51cdeae9a867061c32e3b9bbe8784078
Author: jdonnelly <jdonnelly@chromium.org>
Date: Thu May 26 18:12:09 2016

Explicitly set modification_date when loading server entries from db.

Fixes an issue where the modification_date on server cards and profiles
is always set to base::Time::Now().

BUG= 614803 

Review-Url: https://codereview.chromium.org/2008253003
Cr-Commit-Position: refs/heads/master@{#396229}

[modify] https://crrev.com/914445df51cdeae9a867061c32e3b9bbe8784078/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/914445df51cdeae9a867061c32e3b9bbe8784078/components/autofill/core/browser/webdata/autofill_table_unittest.cc

Comment 2 by jdonnelly@chromium.org, May 27 2016

Labels: Merge-Request-52
Status: Verified (was: Started)
Verified in Canary.

Comment 3 by tin...@google.com, May 27 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323ca00fd701fd57c899426e299390b67cac5e8

commit 8323ca00fd701fd57c899426e299390b67cac5e8
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Fri May 27 21:04:11 2016

Explicitly set modification_date when loading server entries from db.

Fixes an issue where the modification_date on server cards and profiles
is always set to base::Time::Now().

BUG= 614803 

Review-Url: https://codereview.chromium.org/2008253003
Cr-Commit-Position: refs/heads/master@{#396229}
(cherry picked from commit 914445df51cdeae9a867061c32e3b9bbe8784078)

Review URL: https://codereview.chromium.org/2011423003 .

Cr-Commit-Position: refs/branch-heads/2743@{#107}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8323ca00fd701fd57c899426e299390b67cac5e8/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/8323ca00fd701fd57c899426e299390b67cac5e8/components/autofill/core/browser/webdata/autofill_table_unittest.cc

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment