New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614791 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 604052



Sign in to add a comment

cc: Open all GMB resources in the browser compositor

Project Member Reported by ccameron@chromium.org, May 25 2016

Issue description

We pass the GMB id for GMB-backed resources from the renderer to the browser.

We should use this id to open the GMB in the browser process, so it can be used directly for compositing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394e5eec470ff9a0d2af4cae796ccd69c86ee783

commit 394e5eec470ff9a0d2af4cae796ccd69c86ee783
Author: ccameron <ccameron@chromium.org>
Date: Thu May 26 01:57:42 2016

Implement GpuMemoryBufferManager::CreateGpuMemoryBufferFromClientId

For buffers created for a child process, open a copy of the buffer in the browser
process before handing the buffer's handle to the child process. When
CreateGpuMemoryBufferFromClientId is called in the browser process, use this
existing copy of the buffer to create a browser-process copy of the buffer.

Update IOSurface implementation to populate the mach port.

BUG= 614791 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1993333002
Cr-Commit-Position: refs/heads/master@{#396084}

[modify] https://crrev.com/394e5eec470ff9a0d2af4cae796ccd69c86ee783/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/394e5eec470ff9a0d2af4cae796ccd69c86ee783/content/browser/gpu/browser_gpu_memory_buffer_manager.h
[modify] https://crrev.com/394e5eec470ff9a0d2af4cae796ccd69c86ee783/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc

Blocking: 604052
A simpler strategy for this is in
https://codereview.chromium.org/2473973002/
Cc: erikc...@chromium.org ericrk@chromium.org
Status: Assigned (was: Started)
If I find time in the next few days, I may try adding the "open IOSurfaces in the browser" strategy for us to Finch.
Status: WontFix (was: Assigned)
This is not being actively investigated at this time. This is not relevant to look at until viz is in place on Mac.

Sign in to add a comment