New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614790 link

Starred by 1 user
Status: Started
Owner:
█ kirtika@chromium.org
Last visit > 30 days ago
Cc:
snanda@chromium.org
semenzato@chromium.org
█ jleong@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Wifi Metrics: Add new histograms for time spent in suspend for each connection status on wake scenario

Project Member Reported by kirtika@google.com, May 25 2016 
UMA metrics today include Network.Shill.Wifi.WifiConnectionStatusOnWake (which reports whether the device is connected or not on a resume from suspend path) and Power.TimeInSuspend (which logs the time spent in suspend). 
For the purpose of identifying benign or non-problematic disconnects, we would like to isolate WifiConnectionStatusOnWake samples with 'wake on wifi disabled, disconnected on wake from suspend' that are valid user-initiated/user-desired suspend cases. 
We identify user-desired suspend cases by assigning a time heuristic. A suspend was normal and user-desired if it lasted > X seconds (say X =10). 
Add a new metric that logs the time spent in suspended state for each scenario of connection status on wake.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/25d0a0ea4ae89ea08d1c596473e3699373f984ae

commit 25d0a0ea4ae89ea08d1c596473e3699373f984ae
Author: Kirtika Ruchandani <kirtika@google.com>
Date: Wed May 25 06:26:13 2016

Add new histograms for time spent in suspend

When we resume from suspend, the wifi connection status
can be one of 4 scenarios as described by the
WiFiConnectionStatusOnWake metric. For each of these
scenarios, we would like to track the time spent in suspended
state. We consider it normal that the wifi disconnects after
a resume after a long time in suspend, but not after a short
time. This metric will help us remove the non-problematic
disconnect cases from the total number of disconnects, which
are reported in Network.Shill.WiFi.Disconnect.

BUG=chromium:614790
TEST=shill unit-test suite, ran suspend_stress_test on cyan

Change-Id: I2ed42a375c03538d8103548c9679319e78aba777
Reviewed-on: https://chromium-review.googlesource.com/347400
Commit-Ready: Kirtika Ruchandani <kirtika@google.com>
Tested-by: Kirtika Ruchandani <kirtika@google.com>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/metrics.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/power_manager.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/power_manager.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/wake_on_wifi.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/mock_manager.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/mock_manager.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/mock_wake_on_wifi.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/power_manager_unittest.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/manager.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/wake_on_wifi.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/metrics.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/dbus/chromeos_power_manager_proxy.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/power_manager_proxy_interface.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/wake_on_wifi_unittest.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/wifi_unittest.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/mock_metrics.h
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/wifi/wifi.cc
[modify] https://crrev.com/25d0a0ea4ae89ea08d1c596473e3699373f984ae/metrics_unittest.cc
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56

commit de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56
Author: kirtika <kirtika@chromium.org>
Date: Thu Jul 07 02:40:53 2016

Add time in suspended state histograms for Shill

Add Network.Shill.WiFi.SuspendDuration* histograms
to track time spent in suspended state for different
cases of connection status on resume.

BUG=614790

Review-Url: https://codereview.chromium.org/2119253002
Cr-Commit-Position: refs/heads/master@{#404038}

[modify] https://crrev.com/de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment