New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614789 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Move GpuVideoDecoder::decoder_texture_target_ and pixel_format_ to the media::PictureBuffer

Project Member Reported by jbau...@chromium.org, May 25 2016

Issue description

That way different picture buffers can have different formats, which may be necessary if the decoder has to change behavior in some circumstances.
 

Comment 1 by c.pa...@samsung.com, May 11 2017

Cc: c.pa...@samsung.com
I have created a patch for this. PTAL.
https://codereview.chromium.org/2881553002/

Comment 2 by c.pa...@samsung.com, May 19 2017

Cc: -c.pa...@samsung.com jbau...@chromium.org liber...@chromium.org
Owner: c.pa...@samsung.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d264e4712c7c599d78ca2d615b692f1a9f68e325

commit d264e4712c7c599d78ca2d615b692f1a9f68e325
Author: c.padhi <c.padhi@samsung.com>
Date: Fri May 19 17:43:35 2017

Add |texture_target_| and |pixel_format_| to media::PictureBuffer

This CL moves |decoder_texture_target_| and |pixel_format_| from
{Gpu,RTC}VideoDecoder to media::PictureBuffer.
This will allow different picture buffers to have different formats.

BUG= 614789 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2881553002
Cr-Commit-Position: refs/heads/master@{#473236}

[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/content/renderer/media/gpu/rtc_video_decoder.h
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/filters/gpu_video_decoder.h
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/gpu/ipc/service/gpu_video_decode_accelerator.h
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/video/picture.cc
[modify] https://crrev.com/d264e4712c7c599d78ca2d615b692f1a9f68e325/media/video/picture.h

Comment 4 by c.pa...@samsung.com, May 22 2017

Status: Fixed (was: Started)

Sign in to add a comment