Issue 614780 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ rspangler@chromium.org Last visit > 30 days ago
Closed:	May 2016
Cc:	reinauer@chromium.org █ pgeorgi@chromium.org adurbin@chromium.org jwer...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-53 VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 611535

depthcharge: Remove support for legacy RO/RW verified boot

Project Member Reported by rspangler@chromium.org, May 25 2016

Issue description

All current platforms use unified boot in depthcharge (USE=unified_depthcharge), which uses vboot2 for firmware verification.

The old readonly / readwrite depthcharge is no longer used (as .  It's now in the way of refactoring the vboot_reference code to get rid of the vboot1 library, because the readonly code calls the old vboot1 VbInit() and VbSelectAndLoadFirmware() APIs.

So, let's get rid of that old code.

Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/75f4768718cf631e8f6caa41801d2afddb2ec078

commit 75f4768718cf631e8f6caa41801d2afddb2ec078
Author: Randall Spangler <rspangler@chromium.org>
Date: Thu May 19 20:09:42 2016

vboot: Remove legacy main routines

The legacy vboot main (ro_main and rw_main) is unused by any current
boards; everything now uses depthcharge_unified.  The legacy mains make
calls to the vboot1 library in vboot_reference, which is being removed
in favor of vboot2.

Remove this dead code.  No change to the unified main routine or
anything it calls.

BUG= chromium:614780 
BRANCH=none
TEST=build samus; run PFQ to test building other current boards

Change-Id: Ibb101b7021dde2aa9d9d1172b4f340fabe6aad91
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/347414
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/vboot/Makefile.inc
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/vboot/rw_main.c
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/Makefile.inc
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/vboot/stages.h
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/Makefile.inc
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/vboot/ro_main.c
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/Makefile
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/arch/x86/Makefile.inc
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/image/startrw.c
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/vboot/callbacks/load_firmware.c
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/vboot/stages.c
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/vboot/callbacks/Makefile.inc
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/image/startrw.h
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/vboot/util/Makefile.inc
[modify] https://crrev.com/75f4768718cf631e8f6caa41801d2afddb2ec078/src/image/Makefile.inc
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/arch/x86/commonparams.c
[delete] https://crrev.com/5fa24479919be65cb833b1d6d986cc5df7c88ccf/src/vboot/util/find_commonparams.c