New issue
Advanced search Search tips

Issue 614779 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

telemetry: remove dependency on FormBasedCredentialsBackend as its deprecated.

Project Member Reported by tbroch@chromium.org, May 25 2016

Issue description

In running power_LoadTest on M-53 noticed this warning ...

11:58:37 WARNI| /usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_credentials.py:28: UserWarning: Class FormBasedCredentialsBackend is deprecated. It will no longer be supported on May 05, 2017. Please remove it or switch to an alternative before that time. Use the login helper modules in https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/ instead.

  codepen_credentials_backend.CodePenCredentialsBackend(),


 
Which benchmark is this? It would be great if someone from cros team can help with this migration.
Labels: -Pri-3 OS-Chrome Pri-2
Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)
I see this on all chromeos test runs. I was assuming this was something transient on all platforms, but I guess not.
Cc: abodenha@chromium.org
Status: Untriaged (was: Assigned)
Albert, in case there's someone on the team that you'd like to load balance this to. It should be pretty easy to track down. Otherwise I'll take a look next week.
Cc: achuith@chromium.org
Owner: glevin@chromium.org
Status: Assigned (was: Untriaged)
Greg, Albert suggested I assign this to you to take a look.

The easiest way to reproduce this is to run the following command:
<path_to_chromium_src>/src/third_party/catapult/telemetry/bin/run_tests --browser=cros-chrome --remote=<DUT_IP> testBrowserCreation

You should see messages about various CredentialsBackends being deprecated. Please investigate.
Cc: -achuith@chromium.org glevin@chromium.org
Owner: achuith@chromium.org
Status: Started (was: Assigned)
Looks like this is no longer happening. Will verify when I'm back in Mtn View.

Comment 6 by tbroch@chromium.org, Jul 14 2016

Status: Verified (was: Started)
Agreed ... no longer see it in latest M-53 or M-54.

For example, https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/69508687-chromeos-test/chromeos4-row8-rack3-host15/power_LoadTest

Tests that use form_base-credentials_backend will still trigger this warning. (see https://codereview.chromium.org/2050863003/)

Comment 8 by tbroch@chromium.org, Jul 14 2016

Status: Started (was: Verified)
Ah .. yes perhaps too hasty a comment ... I should simply state that power_LoadTest runs aren't showing it and leave status unchanged then.

Thanks for clarifying
Todd: Is this still happening?
Not seeing it on power_LoadTest at least.
Status: Fixed (was: Started)
Thanks!

Comment 12 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 13 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 17 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment