New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614771 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Title bar is accessible via touch in kiosk app, allowing app to be exited

Reported by raniel...@gmail.com, May 25 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS armv7l 7978.69.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36
Platform: 7978.69.0 (Official Build) stable-channel veyron_minnie

Steps to reproduce the problem:
1. On a convertible Chromebooks such as a ASUS flip either launch a kiosk app when in table mode, or start in laptop mode and switch to table mode.

2. Swipe down from the top and the title bar will appear. NOTE: this doesn't happen when in laptop mode, only when in tablet mode

3. Press X and app will exit, press _ and app will disappear.

What is the expected behavior?
Title bar should not appear when swiping down from the top of the screen.

What went wrong?
App exits or disappears

WebStore page: https://chrome.google.com/webstore/detail/sample-test-kiosk-app/melmempfncibgepnoebbmgklmdogpnoj

Did this work before? N/A 

Chrome version: 50.0.2661.94  Channel: n/a
OS Version: 7978.69.0
Flash Version: Shockwave Flash 21.0 r0
 
20160525_131621.mp4
11.4 MB Download
Cc: abodenha@chromium.org maxkirsch@chromium.org
Labels: -Pri-2 Pri-1
Status: Available (was: Unconfirmed)
Thanks for the report.  abodenha@ can you assign this to someone with knowledge of the tablet mode UI code?

Comment 2 by soushi@chromium.org, Oct 14 2016

Cc: soushi@chromium.org
Labels: Hotlist-Enterprise
Owner: abodenha@chromium.org
Hi abodenha@

Do you have the ETA of this issue? I confirmed that it is still reproducible on Chrome 53.0.2785.36, Platform 8530.35.0-16.07.29 on Asus Flip. One of enterprise customer is affected by this issue. 
When minimize the app, the device only shows wallpaper, there are no windows. Even though reverting to the laptop mode, keyboard is not working since there are no windows. It seems like broken device.
Components: -Platform>Apps UI>Shell>TouchView UI>Shell>Kiosk
Labels: M-56
Owner: jen...@chromium.org
Sorry. This slipped through the cracks of the hundreds of other bugs I've been CCed on.

Please don't set the status to "Available" and blank owner for high priority issues.

jennyz@ can you take a look at this? If there is a simple/safe fix we can merge to 55.

I'd think touchview mode should have zero effect on a device in kiosk mode.
Cc: harpreet@chromium.org mlight@chromium.org
Hey team, is there an update in this bug?.

Comment 6 by t...@dropzone.us, Oct 26 2016

Hello, checking in on this issue.  We are the affected enterprise customer.

Comment 7 by mlight@google.com, Oct 26 2016

I was able to reproduce the exposed title bar on a minnie chromebook (chromde 53.0.2785.65, build 8530.57.0), but not on two touch-screen chromebases (buddy and sumo).

Comment 8 by raniel...@gmail.com, Jan 25 2017

Is this still targeted for M56?
jennyz, could you provide an update?
Owner: zork@chromium.org
Status: Assigned (was: Available)

Comment 11 by zork@chromium.org, Feb 22 2017

Owner: x...@chromium.org

Comment 12 by x...@chromium.org, Feb 24 2017

Status: Started (was: Assigned)
https://codereview.chromium.org/2715993002/ in review.
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b75b8d38e4d7575ba77e578710e711f1c6d2e581

commit b75b8d38e4d7575ba77e578710e711f1c6d2e581
Author: xdai <xdai@chromium.org>
Date: Fri Feb 24 22:52:57 2017

[Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}

[modify] https://crrev.com/b75b8d38e4d7575ba77e578710e711f1c6d2e581/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Comment 14 by x...@chromium.org, Feb 24 2017

Status: Fixed (was: Started)

Comment 15 by x...@chromium.org, Feb 25 2017

Labels: Merge-Request-57
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 25 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd7e9309274d2623362df0526cb922919a66d5b

commit fdd7e9309274d2623362df0526cb922919a66d5b
Author: xdai <xdai@chromium.org>
Date: Mon Feb 27 18:41:14 2017

[Merge to M57][Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.

When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.

BUG= 614771 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
(cherry picked from commit b75b8d38e4d7575ba77e578710e711f1c6d2e581)

Review-Url: https://codereview.chromium.org/2718153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#699}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdd7e9309274d2623362df0526cb922919a66d5b/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc

Owner: mlight@chromium.org
Status: Verified (was: Fixed)
Verified in M-57 build 9202.54.0; M-58 build 9334.18.0; M-59 build 9390.0.0.

Sign in to add a comment