New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614754 link

Starred by 1 user
Status: WontFix
Owner:
stkhapugin@chromium.org
Closed: Apr 2017
Cc:
█ lpromero@chromium.org
sdefresne@chromium.org
skare@chromium.org
isherman@chromium.org
ios-bugs@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Move occurences of web::Record*Action to base::Record*Action in ios downstream repo

Reported by beaudoin@chromium.org, May 25 2016 
ios/web/public/user_metrics.h is deprecated and replaced by base/metrics/user_metrics.h. Calls to web::RecordAction and web::RecordComputedAction should therefore be moved to their base:: equivalent.

A CL has been written to do this in the public repo, but there are still 170+ references in the downstream repo.

Ref: https://codereview.chromium.org/2013853002/

Comment 1 by justincohen@chromium.org, May 25 2016

Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)
Since you are tomorrow's sheriff.

Comment 2 by lpromero@chromium.org, May 25 2016

Cc: lpromero@chromium.org
Owner: stkhapugin@chromium.org
Since you are tomorrow's sheriff.

Comment 3 by liaoyuke@chromium.org, Apr 19 2017

Components: Internals>Metrics

Comment 4 by sdefresne@chromium.org, Apr 20 2017

Status: WontFix (was: Assigned)
Obsolete, this has been fixed a long time ago.

$ cd src/ios_internal
$ git grep user_metrics.h
DEPS:  "+base/metrics/user_metrics.h",
chrome/browser/providers/native_app_launcher/google_native_app_metadata.mm:#include "base/metrics/user_metrics.h"
chrome/browser/providers/signin/chrome_identity_interaction_manager_impl.mm:#include "base/metrics/user_metrics.h"
chrome/browser/providers/ui/ntp/logo_container_view.mm:#include "base/metrics/user_metrics.h"
chrome/browser/providers/ui/voice/glif_voice_search_bar_view.mm:#include "base/metrics/user_metrics.h"
►

Sign in to add a comment