New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614752 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"VRService not found" errors on stderr

Project Member Reported by rbyers@chromium.org, May 25 2016

Issue description

Sometime recently content_shell started spewing messages like the following to stderr:

[3224:5696:0525/080942:8809688:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found
[3224:5696:0525/080942:8809688:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found

This is massively polluting layoutest results.  Eg. see all the "Tests that had stderr output" at https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel_ng/227862/layout-test-results/results.html

From a quick scan of recent commit history, my best guess is https://codereview.chromium.org/1967633002 or maybe https://codereview.chromium.org/1808203005

bajones can you please take a look?


 
Status: Assigned (was: Unconfirmed)
I'll take a look, but I don't think I'll have a chance to till Friday due to travel.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f7b25a40b187d5214eafdc86190b811c247580a

commit 8f7b25a40b187d5214eafdc86190b811c247580a
Author: bajones <bajones@chromium.org>
Date: Thu Jun 02 08:17:14 2016

Stopped WebVR from being partially enabled during testing.

Should prevent repeated instances of "blink::mojom::VRService not found" in test
logs.

BUG= 614752 

Review-Url: https://codereview.chromium.org/2029843002
Cr-Commit-Position: refs/heads/master@{#397335}

[modify] https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a/content/child/runtime_features.cc
[modify] https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d4d2467316e320d44d59db7113d6474549bf617

commit 8d4d2467316e320d44d59db7113d6474549bf617
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 11:53:43 2016

Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )

Reason for revert:
Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
For more info see:
BUG=616730

Original issue's description:
> Stopped WebVR from being partially enabled during testing.
>
> Should prevent repeated instances of "blink::mojom::VRService not found" in test
> logs.
>
> BUG= 614752 
>
> Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> Cr-Commit-Position: refs/heads/master@{#397335}

TBR=esprehn@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 614752 

Review-Url: https://codereview.chromium.org/2030913002
Cr-Commit-Position: refs/heads/master@{#397372}

[modify] https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617/content/child/runtime_features.cc
[modify] https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc1a78a173991463b44ea98822994f80075b1c5

commit afc1a78a173991463b44ea98822994f80075b1c5
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 11:58:42 2016

Reland of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2030913002/ )

Reason for revert:
This revert was speculative and the test proved to be too flaky for the revert results to be conclusive.

Sorry for the noise, relanding.

Original issue's description:
> Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )
>
> Reason for revert:
> Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
> For more info see:
> BUG=616730
>
> Original issue's description:
> > Stopped WebVR from being partially enabled during testing.
> >
> > Should prevent repeated instances of "blink::mojom::VRService not found" in test
> > logs.
> >
> > BUG= 614752 
> >
> > Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> > Cr-Commit-Position: refs/heads/master@{#397335}
>
> TBR=esprehn@chromium.org,bajones@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 614752 
>
> Committed: https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617
> Cr-Commit-Position: refs/heads/master@{#397372}

TBR=esprehn@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616730

Review-Url: https://codereview.chromium.org/2030023002
Cr-Commit-Position: refs/heads/master@{#397373}

[modify] https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5/content/child/runtime_features.cc
[modify] https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Status: Fixed (was: Assigned)

Comment 6 by rbyers@chromium.org, Jun 23 2016

Status: Assigned (was: Fixed)
Still seeing this.  Will comment on the CL.
Status: Fixed (was: Assigned)
WebVR's renderer/browser communication was recently refactored and is now exclusively lazily initialized. That prevents this issue.

Sign in to add a comment