New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614742 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
lfg@chromium.org
wjmaclean@chromium.org
agrieve@google.com
rouslan@chromium.org
█ groby@chromium.org
█ brettw@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 604645


Sign in to add a comment

NOTREACHED() in WebRemoteFrameImpl::removeSpellingMarkers() under --top-document-isolation

Project Member Reported by nick@chromium.org, May 25 2016 
From a user report:

"""Which sites work with TDI. Tried enabling TDI via about:flags on a ChromePublic build today. Tried CNN, theverge, techchrunch, and they all die with a NOT_IMPLEMENTED in WebRemoteFrameImpl::removeSpellingMarkers. Known issue? work-around?"""

I can't so far repro this on a Windows debug build with cnn.com, so assuming this is an Android issue.

If we're reaching this there may be spellcheck correcntess bugs w/ oopifs in general.

Comment 1 by creis@chromium.org, May 25 2016

Cc: groby@chromium.org
@groby: I think you're aware of some spellcheck work needed to support OOPIFs, right?  I don't think we have a bug on file, but we should start looking into it.

Comment 2 by groby@chromium.org, May 25 2016 

Spellcheck does need work for OOPIF, yes. Happy to assist anybody who can migrate it, but currently don't have spare cycles to do it myself.

(Also, pointer to docs appreciated :)

Comment 3 by groby@chromium.org, May 27 2016

Blockedon: 604645
https://codereview.chromium.org/2012823003/ will remove removeSpellingMarkers from WebRemoteFrameImpl - it's only useful on WebLocalFrame. Please recheck once this has landed (or the associated  bug #604645  has been closed)

Comment 4 by groby@chromium.org, Jun 21 2016

Cc: rouslan@chromium.org wjmaclean@chromium.org lfg@chromium.org
 Issue 622039  has been merged into this issue.

Comment 5 by nasko@chromium.org, Dec 7 2016

Blockedon: 638351
Should this be resolved as duplicate of issue 638351? Or at least being blocked on it?

Comment 6 by groby@chromium.org, Dec 7 2016 

WebRemoteFrameImpl::removeSpellingMarkers has been removed,  bug#604645  has long since landed. 

I'd suppose we can close this?

Comment 7 by creis@chromium.org, Jan 5 2017

Status: WontFix (was: Available)
Closing per comment 6.

Comment 8 by creis@chromium.org, Jan 5 2017

Blockedon: -638351

Comment 9 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment