New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614740 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

XHR Breakpoints don't work with fetch

Reported by wout.mer...@gmail.com, May 25 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36

Steps to reproduce the problem:
1. Set xhr breakpoint for Any
2. Do a fetch request instead of XHR

What is the expected behavior?
3. Breakpoint triggers

What went wrong?
3. Nothing happens, fetch goes through without triggering

Did this work before? N/A 

Chrome version: 50.0.2661.102  Channel: stable
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 21.0 r0

I know it is called XHR breakpoint, but IMHO fetch requests should also trigger the breakpoint.

Comment 1 by eostroukhov@chromium.org, May 25 2016

Components: -Platform>DevTools Platform>DevTools>JavaScript
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by kozyatinskiy@chromium.org, May 25 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2012873002/
Project Member

Comment 3 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd

commit 3cc776e8e1116741baba2f3754e99bfaf4e1c1dd
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu May 26 02:19:49 2016

[DevTools] Add fetch support for XHR breakpoints

BUG= 614740 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2012873002
Cr-Commit-Position: refs/heads/master@{#396088}

[add] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/LayoutTests/http/tests/inspector/debugger/fetch-breakpoints-expected.txt
[add] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/LayoutTests/http/tests/inspector/debugger/fetch-breakpoints.html
[modify] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
[modify] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp

Comment 4 by kozyatinskiy@chromium.org, May 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment