New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove intentionally flaky test to verify that Earl Grey infrastructure works

Project Member Reported by baxley@chromium.org, May 25 2016

Issue description

Earl Grey tests have been running on FYI, but every build has been green since set up. We'd like to (temporarily) have a test that sometimes fails to verify that passes and failures are always correctly identified.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9c93f8c46594e5437074d153222d2c48e754df6

commit e9c93f8c46594e5437074d153222d2c48e754df6
Author: baxley <baxley@chromium.org>
Date: Wed May 25 17:37:00 2016

Create temporary Earl Grey test that is flaky on FYI.

Earl Grey has done several hundred runs on FYI without a test failure.
This is a temporary test that fails 50% of the time, and should be
reverted once it is verified.

BUG= 614729 

Review-Url: https://codereview.chromium.org/2014593002
Cr-Commit-Position: refs/heads/master@{#395927}

[modify] https://crrev.com/e9c93f8c46594e5437074d153222d2c48e754df6/ios/web/shell/test/web_shell_navigation_egtest.mm

Comment 2 by baxley@chromium.org, May 25 2016

Out of the 11 runs that have occurred, 6 passed, while 5 failed and were correctly marked as failure.

I manually looked at the first 7 runs and the test results in the log file matched what the bot said, so I think this is done. I'll revert the original CL.
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097c5b0f7ac025c99f5ef2c6cadefbb09113cbc1

commit 097c5b0f7ac025c99f5ef2c6cadefbb09113cbc1
Author: baxley <baxley@chromium.org>
Date: Wed May 25 22:53:39 2016

Revert "Create temporary Earl Grey test that is flaky on FYI."

This reverts commit e9c93f8c46594e5437074d153222d2c48e754df6.

The previous commit was used to verify that Earl Grey failures are
correctly displayed on the FYI bot.

BUG= 614729 

Review-Url: https://codereview.chromium.org/2016453002
Cr-Commit-Position: refs/heads/master@{#396022}

[modify] https://crrev.com/097c5b0f7ac025c99f5ef2c6cadefbb09113cbc1/ios/web/shell/test/web_shell_navigation_egtest.mm

Comment 4 by baxley@chromium.org, May 26 2016

Status: Fixed (was: Started)

Sign in to add a comment