New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614728 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

memory.top_10_mobile_tbmv2 got disabled by mistake

Project Member Reported by perezju@chromium.org, May 25 2016

Issue description

memory.top_10_mobile_tbmv2 stopped generating data on May 5th, see:
https://chromeperf.appspot.com/report?sid=eac74f4bf6d4544e58fc941cdd98ed4559d30e9a89eafbdb9bac97fa39171720

Right after the last data point my CL https://codereview.chromium.org/1947883002 landed. This, it seems, had the unintended effect of making memory.top_10_mobile_tbmv2 be reported as 'disabled' for Android.

I think this should fix itself now that I've landed https://codereview.chromium.org/1936533002/. But I file this bug anyway to remind us to check.

+Kari, I remember you mentioned something about weird interactions of enabled/disabled decorators when a benchmark subclasses another (which is what I think happened here). Not sure if there is already a tracking bug to get clearer semantics or a doc to document such behaviors.

+Annie, FYI, this will probably start sending another sizable batch of data to the dashboards.
 
Owner: sullivan@chromium.org
As expected, after landing the memory infra cleanup CLs, the benchmark is now enabled again; e.g. there is a recent run here:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%282%29/builds/2920/steps/memory.top_10_mobile_tbmv2/logs/stdio

From the logs it looks like data is uploaded to the dashboards just fine, but I'm still unable to see new points on the dashboard, e.g. for some other random metric of this benchmark:
https://chromeperf.appspot.com/report?sid=2a4f3d456f43512f37c8622686905dcb2fd57a87ec796c241aae62148346d92e

Annie, could you help us triage?
I'm really sorry for the slow response here. I don't see memory.top_10_mobile_tbmv2 running anymore?
It is up and running: https://chromeperf.appspot.com/report?sid=8d595b544320d66e57f36b64f6e6d518996387290f2eb400cfb92df3e5e8d5c8 :-)

The problem is that the old values (which are not reported any more) haven't been renamed yet ( issue 617117 ).
Status: Verified (was: Untriaged)
Yes, thanks! I think this issue can be closed now.

Sign in to add a comment