GPU bots: dcheck_always_on is not always on in Release |
||||
Issue descriptionI was trying to figure out why my change to ANGLE wasn't triggering an ASSERT in Release on any platform other than Windows: https://chromium-review.googlesource.com/#/c/346103/ It looks as though with GN dcheck_always_on is not on for these builds: https://build.chromium.org/p/tryserver.chromium.angle/builders/linux_angle_rel_ng/builds/1340/steps/generate_build_files%20%28with%20patch%29/logs/stdio Writing """\ build_angle_deqp_tests = true ffmpeg_branding = "Chrome" goma_dir = "/b/build/slave/cache/cipd/goma" internal_gles2_conform_tests = true is_component_build = false is_debug = false proprietary_codecs = true use_goma = true """ to /b/build/slave/linux/build/src/out/Release/args.gn. Compare this to the linux_chromium_rel_ng run: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/235241/steps/generate_build_files%20%28with%20patch%29/logs/stdio Writing """\ dcheck_always_on = true ffmpeg_branding = "Chrome" goma_dir = "/b/build/slave/cache/cipd/goma" is_component_build = false is_debug = false proprietary_codecs = true symbol_level = 1 use_goma = true """ to /b/build/slave/linux/build/src/out/Release/args.gn. This seems to affect the ANGLE trybots as well as the GPU and GPU FYI bots. Unsure if it affects other configs. Test CL: https://codereview.chromium.org/2011783003/ Also investigating why the Release ASSERT didn't trigger in my CL on Mac, which should be using GYP. Ken or Nico can you help me figure this one out?
,
May 25 2016
https://codereview.chromium.org/2013683004/
,
May 25 2016
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de78a4363a52721a1a6e96d0eb71a7fbc1a52662 commit de78a4363a52721a1a6e96d0eb71a7fbc1a52662 Author: jmadill <jmadill@chromium.org> Date: Wed May 25 22:43:31 2016 Use dcheck_always_on for GPU FYI Release trybots. This bot config was using release_bot instead of release_trybot. This will enable asserts in release code for these configs. BUG= 614725 R=kbr@chromium.org,thakis@chromium.org Review-Url: https://codereview.chromium.org/2013683004 Cr-Commit-Position: refs/heads/master@{#396015} [modify] https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662/tools/mb/mb_config.pyl
,
May 26 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, May 25 2016tools/mb/mb_config.pyl in a chromium checkout controls which bots build with dcheck_always_on (at least for bots that use mb, which means the bots that have an explicit "generate build files" step, which the bot you linked to has). mb_config.pyl says: 'linux_angle_rel_ng': 'swarming_gpu_fyi_tests_gn_release_trybot', So your bot uses the swarming_gpu_fyi_tests_gn_release_trybot config which is defined like so later in that file: 'swarming_gpu_fyi_tests_gn_release_trybot': [ 'swarming', 'gpu_tests', 'internal_gles2_conform_tests', 'gn', 'release_bot', 'angle_deqp_tests', ], If you want that bot to use dcheck_always_on, add 'dcheck_always_on' to that list of mixins. Here's a different config which sets that, as an example: 'gn_cfi_release_static_dcheck_always_on': [ 'gn', 'cfi', 'release', 'static', 'dcheck_always_on', ],