Issue 614699 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	dougarnett@chromium.org
Closed:	May 2016
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug

PrerenderingLoaderTest failing on asan-clang-phone

Project Member Reported by mvanouwe...@chromium.org, May 25 2016

Issue description

Most of the PrerenderingLoaderTest tests started failing on asan-clang-phone around May 23 22:41:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone?numbuilds=200

This suspect CL modified the tests, fits in the commit range, and matches the time:
https://codereview.chromium.org/1968593002

Logs from first failure:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/314/steps/unit_tests/logs/stdio

I  430.138s Main  6 failed tests remain.
C  430.148s Main  ********************************************************************************
C  430.148s Main  Detailed Logs
C  430.148s Main  ********************************************************************************
C  430.152s Main  [FAIL] PrerenderingLoaderTest.CanPrerender:
C  430.152s Main  [ RUN      ] PrerenderingLoaderTest.CanPrerender
C  430.152s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:156: Failure
C  430.152s Main  Value of: loader()->CanPrerender()
C  430.153s Main    Actual: false
C  430.153s Main  Expected: true
C  430.153s Main  [  FAILED  ] PrerenderingLoaderTest.CanPrerender (24 ms)
C  430.153s Main  [FAIL] PrerenderingLoaderTest.LoadPageLoadCanceledFromStopLoading:
C  430.153s Main  [ RUN      ] PrerenderingLoaderTest.LoadPageLoadCanceledFromStopLoading
C  430.153s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:251: Failure
C  430.153s Main  Value of: loader()->LoadPage( gurl, base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this)))
C  430.153s Main    Actual: false
C  430.153s Main  Expected: true
C  430.153s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:252: Failure
C  430.153s Main  Value of: loader()->IsIdle()
C  430.153s Main    Actual: true
C  430.153s Main  Expected: false
C  430.153s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:259: Failure
C  430.153s Main  Value of: callback_load_status()
C  430.153s Main    Actual: 4-byte object <00-00 00-00>
C  430.153s Main  Expected: Offliner::RequestStatus::CANCELED
C  430.153s Main  Which is: 4-byte object <03-00 00-00>
C  430.153s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadCanceledFromStopLoading (13 ms)
C  430.154s Main  [FAIL] PrerenderingLoaderTest.LoadPageLoadFailedNoContent:
C  430.154s Main  [ RUN      ] PrerenderingLoaderTest.LoadPageLoadFailedNoContent
C  430.154s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:230: Failure
C  430.154s Main  Value of: loader()->LoadPage( gurl, base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this)))
C  430.154s Main    Actual: false
C  430.154s Main  Expected: true
C  430.154s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:231: Failure
C  430.154s Main  Value of: loader()->IsIdle()
C  430.154s Main    Actual: true
C  430.154s Main  Expected: false
C  430.154s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:239: Failure
C  430.154s Main  Value of: callback_load_status()
C  430.154s Main    Actual: 4-byte object <00-00 00-00>
C  430.154s Main  Expected: Offliner::RequestStatus::FAILED
C  430.154s Main  Which is: 4-byte object <04-00 00-00>
C  430.154s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadFailedNoContent (14 ms)
C  430.154s Main  [FAIL] PrerenderingLoaderTest.LoadPageLoadSucceededFromDomContentLoaded:
C  430.154s Main  [ RUN      ] PrerenderingLoaderTest.LoadPageLoadSucceededFromDomContentLoaded
C  430.155s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:177: Failure
C  430.155s Main  Value of: loader()->LoadPage( gurl, base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this)))
C  430.155s Main    Actual: false
C  430.155s Main  Expected: true
C  430.155s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:181: Failure
C  430.155s Main  Value of: loader()->IsIdle()
C  430.155s Main    Actual: true
C  430.155s Main  Expected: false
C  430.155s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:182: Failure
C  430.155s Main  Value of: loader()->IsLoaded()
C  430.155s Main    Actual: false
C  430.155s Main  Expected: true
C  430.155s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:184: Failure
C  430.155s Main  Value of: callback_load_status()
C  430.155s Main    Actual: 4-byte object <00-00 00-00>
C  430.155s Main  Expected: Offliner::RequestStatus::LOADED
C  430.155s Main  Which is: 4-byte object <01-00 00-00>
C  430.155s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadSucceededFromDomContentLoaded (95 ms)
C  430.155s Main  [FAIL] PrerenderingLoaderTest.LoadPageNotAcceptedWhenNotIdle:
C  430.156s Main  [ RUN      ] PrerenderingLoaderTest.LoadPageNotAcceptedWhenNotIdle
C  430.156s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:267: Failure
C  430.156s Main  Value of: loader()->LoadPage( gurl, base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this)))
C  430.156s Main    Actual: false
C  430.156s Main  Expected: true
C  430.156s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:268: Failure
C  430.156s Main  Value of: loader()->IsIdle()
C  430.156s Main    Actual: true
C  430.156s Main  Expected: false
C  430.156s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:275: Failure
C  430.156s Main  Value of: loader()->IsIdle()
C  430.156s Main    Actual: true
C  430.156s Main  Expected: false
C  430.156s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageNotAcceptedWhenNotIdle (14 ms)
C  430.156s Main  [CRASH] PrerenderingLoaderTest.LoadPageLoadSucceededFromPrerenderStopLoading:
C  430.156s Main  [ RUN      ] PrerenderingLoaderTest.LoadPageLoadSucceededFromPrerenderStopLoading
C  430.156s Main  ../../chrome/browser/android/offline_pages/prerendering_loader_unittest.cc:200: Failure
C  430.156s Main  Value of: loader()->LoadPage( gurl, base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this)))
C  430.157s Main    Actual: false
C  430.157s Main  Expected: true
C  430.157s Main  [FATAL:prerendering_loader.cc(85)] Check failed: state_ == State::PENDING. 
C  430.157s Main  #00 0x7aceb567 /data/app-lib/org.chromium.native_test-1/libbase.cr.so+0x000e8567
C  430.157s Main  #01 0x8ba4a267 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x0183b267
C  430.157s Main  #02 0x8af6b919 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x00d5c919
C  430.157s Main  #03 0x8c6fc18d /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024ed18d
C  430.157s Main  #04 0x8c6fd7e1 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024ee7e1
C  430.157s Main  #05 0x8c6fe567 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024ef567
C  430.157s Main  #06 0x8c70a163 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024fb163
C  430.157s Main  #07 0x8c709999 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024fa999
C  430.157s Main  #08 0x8b15423d /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x00f4523d
C  430.157s Main  #09 0x8b158e71 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x00f49e71
C  430.157s Main  #10 0x8b146505 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x00f37505
C  430.157s Main  #11 0x8c6c4411 /data/app-lib/org.chromium.native_test-1/lib_unit_tests__library.cr.so+0x024b5411
C  430.157s Main  #12 0x43f1dbcf /system/lib/libdvm.so+0x0001dbcf
C  430.157s Main  #13 0x43f4e125 /system/lib/libdvm.so+0x0004e125
C  430.157s Main  #14 0x43f26fe3 /system/lib/libdvm.so+0x00026fe3
C  430.157s Main  #15 0x43f2dfa3 /system/lib/libdvm.so+0x0002dfa3
C  430.158s Main  #16 0x43f2b63b /system/lib/libdvm.so+0x0002b63b
C  430.158s Main  #17 0x43f60863 /system/lib/libdvm.so+0x00060863
C  430.158s Main  #18 0x43f687c5 /system/lib/libdvm.so+0x000687c5
C  430.158s Main  #19 0x43f26fe3 /system/lib/libdvm.so+0x00026fe3
C  430.158s Main  #20 0x43f2dfa3 /system/lib/libdvm.so+0x0002dfa3
C  430.158s Main  #21 0x43f2b63b /system/lib/libdvm.so+0x0002b63b
C  430.158s Main  #22 0x43f6057f /system/lib/libdvm.so+0x0006057f
C  430.158s Main  #23 0x43f49d0d /system/lib/libdvm.so+0x00049d0d
C  430.158s Main  #24 0x406e52b3 /system/lib/libandroid_runtime.so+0x0004d2b3
C  430.158s Main  #25 0x406e5fd9 /system/lib/libandroid_runtime.so+0x0004dfd9
C  430.158s Main  #26 0x4004705d /system/bin/app_process32+0x0000105d
C  430.158s Main  #27 0x405cf34b /system/lib/libc.so+0x0000e34b
C  430.158s Main  #28 0x40046d7f /system/bin/app_process32+0x00000d7f
C  430.158s Main  
C  430.158s Main  [ERROR:test_suite.cc(254)] Currently running: PrerenderingLoaderTest.LoadPageLoadSucceededFromPrerenderStopLoading
C  430.158s Main  ********************************************************************************
C  430.158s Main  Summary
C  430.158s Main  ********************************************************************************
C  430.162s Main  [==========] 2184 tests ran.
C  430.162s Main  [  PASSED  ] 2178 tests.
C  430.162s Main  [  FAILED  ] 6 tests, listed below:
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.CanPrerender
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadCanceledFromStopLoading
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadFailedNoContent
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadSucceededFromDomContentLoaded
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageNotAcceptedWhenNotIdle
C  430.162s Main  [  FAILED  ] PrerenderingLoaderTest.LoadPageLoadSucceededFromPrerenderStopLoading (CRASHED)
C  430.162s Main  
C  430.162s Main  6 FAILED TESTS
C  430.162s Main  ********************************************************************************

Comment 1 by dougarnett@chromium.org, May 25 2016

Components: UI>Browser>Offline

Looks like simple issue with not initializing a bool member variable. 
Have pending CL and waiting on asan-clang-phone bot to start running.

Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2f237c4acbdd9e0f6495b688f2c3da86127cac

commit bd2f237c4acbdd9e0f6495b688f2c3da86127cac
Author: dougarnett <dougarnett@chromium.org>
Date: Thu May 26 16:00:14 2016

PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in  issue 614699 .]

It proved challenging to write unittests wrt mocking PrerenderManager and/or PrerenderHandler and be able to create a stub PrerenderHandler without touching the prerender stack code so this CL takes the approach of adding an adapter between the Loader and prerender stack calls so that they can be intercepted for testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chromium.org
BUG= 601173 , 614699 

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001 (http://crrev.com/1968593002#ps420001)

Review-Url: https://codereview.chromium.org/2015603002
Cr-Commit-Position: refs/heads/master@{#396191}

[add] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerender_adapter.cc
[add] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerender_adapter.h
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_loader.cc
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_loader.h
[add] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/chrome_browser.gypi
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/components/offline_pages/background/offliner.h
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac/components/offline_pages/background/request_coordinator_unittest.cc

Comment 3 by dougarnett@chromium.org, May 31 2016

Status: Fixed (was: Assigned)

►

Issue 614699 link

Issue metadata

PrerenderingLoaderTest failing on asan-clang-phone

Issue description

Comment 1 by dougarnett@chromium.org, May 25 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 26 2016

Comment 2 Deleted

Comment 3 by dougarnett@chromium.org, May 31 2016

Comment 3 Deleted

Sign in to add a comment